Repository navigation
test: pin launch_sandbox.py behavior, document it in the runbook - #73
Merged
Merged
Conversation
launch_sandbox.py ships at the repo root but was mentioned in no doc and covered by no test. Its mapping (PAYPAL_SANDBOX_* to PERMIT_PAYPAL_*), its hardcoded merchant override, its missing-credentials exit, and its FileNotFoundError crash on a missing .env.sandbox are now pinned by subprocess tests against a fake server.py, and the sandbox runbook documents both credential paths and both failure modes. Suite: 417 passed, 3 skipped.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
FetchDoge
pushed a commit
that referenced
this pull request
Nov 3, 2026
README claimed 413 passed / 416 collected verified 2026-10-29 at 3280b92, but PRs #73 and #74 added 12 tests: main at 20c74bf runs 425 passed, 3 skipped (428 collected), re-verified locally 2026-11-03. The Status line also still carried the pre-shift targets (video by Nov 8, Devpost by Nov 10); the readiness target moved 2026-11-02 to video by Nov 6 (M5) and submission-ready Nov 9 (M6). Docs only, no code change.
FetchDoge
added a commit
that referenced
this pull request
Nov 3, 2026
README claimed 413 passed / 416 collected verified 2026-10-29 at 3280b92, but PRs #73 and #74 added 12 tests: main at 20c74bf runs 425 passed, 3 skipped (428 collected), re-verified locally 2026-11-03. The Status line also still carried the pre-shift targets (video by Nov 8, Devpost by Nov 10); the readiness target moved 2026-11-02 to video by Nov 6 (M5) and submission-ready Nov 9 (M6). Docs only, no code change. Co-authored-by: Marcus Richards <marsoju@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
launch_sandbox.py ships at the repo root but was mentioned in no doc and covered by no test. This PR pins its actual behavior with subprocess tests (fake server.py under a temp PERMIT_ROOT: env mapping PAYPAL_SANDBOX_* to PERMIT_PAYPAL_*, hardcoded merchant override, missing-credentials exit 1 before launch, FileNotFoundError on a missing .env.sandbox) and documents both credential paths and both failure modes in docs/sandbox-runbook.md. Draft PR #65 documented the same launcher section from reading the code; this version is proven by tests. Suite: 417 passed, 3 skipped (413 baseline + 4 new), ruff clean on the new test file.