Skip to content

Upgrade example to React Native 0.88 - #343

Merged
pecanoro merged 14 commits into
masterfrom
monil-upgradeReactNative
Nov 12, 2026
Merged

pecanoro merged 14 commits into
masterfrom
monil-upgradeReactNative

Conversation

@MonilBhavsar

@MonilBhavsar MonilBhavsar commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Summary

For https://github.com/Expensify/Expensify/issues/701873

  • Upgrade the example from React Native 0.63.2 to 0.88.1 and remove the vulnerable npm hermes-engine dependency.
  • Add a separate new-architecture iOS share controller, retaining the existing controller for older React Native versions.
  • Update the example's iOS and Android projects, adopt the iOS scene lifecycle, and handle iOS share payloads.

Tests

  • yarn install --frozen-lockfile
  • yarn test --runInBand (6 tests)
  • ESLint on the changed JavaScript with Flow/JSX parser options (1 existing inline-style warning; default parsing of App.js fails due to the React Native Babel parser)
  • iOS simulator build and build-for-testing (arm64, code signing disabled)
  • Android debug build (arm64-v8a)
  • pod install --deployment
  • Bundled index.share.js with Metro
  • Verified that neither hermes-engine nor decode-uri-component is in the npm dependency tree.

iOS

  1. Open Test and confirm it displays “React Native Share Menu.”
  2. In Safari, open https://example.com and tap Share.
  3. Select ShareExtension or Test; use More if it’s hidden.
  4. Confirm the link appears in the share screen.
  5. Tap Dismiss and confirm the share screen closes.
  6. Repeat with a photo from Photos and confirm its preview appears.
Screenshot iPhone 18 Pro 12-11-2026 at 2 23 20 AM Screenshot iPhone 18 Pro 12-11-2026 at 2 26 16 AM Screenshot iPhone 18 Pro 12-11-2026 at 2 24 38 AM

Android

  1. Open Chrome in the emulator and visit https://example.com.
  2. Tap ⋮ → Share → example.
  3. Confirm the app displays the link under Shared text.
  4. Repeat with another link while the app is already running, then try sharing a photo.
Screenshot_1794431193 Screenshot_1794431257 Screenshot_1794431389

@MonilBhavsar
MonilBhavsar marked this pull request as ready for review November 11, 2026 21:11
@MonilBhavsar

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-11T21:22:12.389718Z f7b3d26 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: f7b3d265ce

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@MonilBhavsar
MonilBhavsar requested a review from a team November 11, 2026 21:24
@melvin-bot
melvin-bot Bot requested review from pecanoro and removed request for a team November 11, 2026 21:24
@pecanoro

Copy link
Copy Markdown
Contributor

@MonilBhavsar there are conflicts

@pecanoro
pecanoro merged commit 921c29f into master Nov 12, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants