Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QqAbYSeeLRcFL18iy8t9DC
melvin-bot
Bot
requested review from
stitesExpensify
and removed request for
a team
November 12, 2026 09:48
Author
|
Closing as superseded by #343. The React Native 0.88 upgrade rebuilt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
The open
bracesDependabot alerts point toexample/yarn.lock, which resolvesbracesto 2.3.2 (viamicromatch@3) and 3.0.2 (viamicromatch@4). The fix is in 3.0.3, and there is no patched 2.x release.This adds a
braces: ^3.0.3resolution to the example app, so both paths resolve to 3.0.3. It also bumpsfill-rangeto 7.1.1 and removes lock entries that only braces 2.x used (fill-range@4,to-regex-range@2,repeat-element,repeat-string,snapdragon-node,snapdragon-util). Only the example app is affected. The library itself has no dependencies.micromatch@3now gets braces 3.x, which is outside its requested^2.3.1range. I ran micromatch 3.1.10 with braces 2.3.2 and then with 3.0.3 against common globs: brace lists, numeric ranges, negation,**,isMatch,makeRe,bracesandany. The results were identical.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/701867
Tests
example/, runyarn install --frozen-lockfile --ignore-scripts.yarn why bracesand check that the only version is 3.0.3.Verified with Yarn 1.22.22: the frozen-lockfile install succeeds, and
yarn why bracesreports onlybraces@3.0.3, used by everymicromatchconsumer (anymatch,sane, and Metro'sjest-haste-map).🤖 Generated with Claude Code
https://claude.ai/code/session_01QqAbYSeeLRcFL18iy8t9DC