Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/diagrams/generated/_index.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/diagrams/generated/_overview.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ kind: overview
codebase: visioncraft
---
# visioncraft overview
10 files · 184 symbols · 692 relations · 90 flows · 586 calls
10 files · 184 symbols · 692 relations · 90 flows · 587 calls

## crates
```mermaid
Expand Down
9 changes: 6 additions & 3 deletions docs/diagrams/generated/src/evidence.rs.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ sealmap: 2
source: src/evidence.rs
module: "sym:cargo visioncraft . evidence/"
language: rust
source_hash: blake3:edfe990a885f2bcad685855fe0c87e11878174d676e4414f4f9448e818ca520a
lines: 292
source_hash: blake3:828bcb80eba9b50585cd3d8e0dc360f40716b3824a508fc60b52fcd1514d0f77
lines: 301
fragments: 2
---
# `sym:cargo visioncraft . evidence/` · src/evidence.rs
Expand Down Expand Up @@ -136,7 +136,7 @@ classDiagram
```

## `sym:cargo visioncraft . evidence/ExecutionReceipt#validate().`
`pub fn validate(&self) -> Result<(), ContractError>` · L107-L178
`pub fn validate(&self) -> Result<(), ContractError>` · L107-L187
> Check receipt consistency; matching a plan and bytes is a separate step.
```mermaid
sequenceDiagram
Expand Down Expand Up @@ -170,6 +170,9 @@ sequenceDiagram
visioncraft__evidence___tExecutionReceipt->>visioncraft: require(_, #quot;completed ex…)?
else
visioncraft__evidence___tExecutionReceipt->>visioncraft: require(is_some_and(), #quot;incomplete e…)?
opt self.process == ProcessStatus::FailedToStart || self…
visioncraft__evidence___tExecutionReceipt->>visioncraft: require(_, #quot;a process th…)?
end
end
loop for a in self.stdout.iter().chain(self.stderr.iter())
visioncraft__evidence___tExecutionReceipt->>visioncraft: artifact_shape(a)?
Expand Down
11 changes: 10 additions & 1 deletion src/evidence.rs
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,8 @@ impl ExecutionReceipt {
///
/// # Errors
/// Refuses incomplete identities, impossible timestamps and success records
/// lacking complete capture or an exit code.
/// lacking complete capture or an exit code, and never-started processes
/// claiming an exit code or signal.
pub fn validate(&self) -> Result<(), ContractError> {
require(self.version == 1, "unsupported receipt version")?;
require(
Expand Down Expand Up @@ -150,6 +151,14 @@ impl ExecutionReceipt {
self.diagnostic.as_deref().is_some_and(nonempty),
"incomplete execution requires a diagnostic",
)?;
if self.process == ProcessStatus::FailedToStart
|| self.process == ProcessStatus::Unavailable
{
require(
self.exit_code.is_none() && self.signal.is_none(),
"a process that never started cannot report an exit code or signal",
)?;
}
}
for a in self.stdout.iter().chain(self.stderr.iter()) {
artifact_shape(a)?;
Expand Down
37 changes: 37 additions & 0 deletions tests/core.rs
Original file line number Diff line number Diff line change
Expand Up @@ -754,6 +754,43 @@ fn valid_individual_checks_cannot_form_an_unbounded_aggregate_plan() {
);
}

#[test]
fn never_started_executions_cannot_claim_an_exit_code_or_signal() {
let plan = plan();
let mut verified = VerifiedArtifacts::default();
for status in [ProcessStatus::FailedToStart, ProcessStatus::Unavailable] {
let mut forged = receipt(&plan, "main", &mut verified);
forged.process = status;
forged.diagnostic = Some("fixture never launched a process".into());
forged.capture_complete = false;
assert!(
forged.validate().is_err(),
"{status:?} cannot claim a reaped exit code"
);
assert_eq!(
report(&plan, std::slice::from_ref(&forged), &verified).outcome,
GateOutcome::Error,
"{status:?}: a claimed result from a never-started process is invalid"
);
let mut signalled = forged.clone();
signalled.exit_code = None;
signalled.signal = Some(9);
assert!(
signalled.validate().is_err(),
"{status:?} cannot claim a signal"
);
forged.exit_code = None;
assert!(
forged.validate().is_ok(),
"{status:?} without results remains valid"
);
assert!(
!report(&plan, std::slice::from_ref(&forged), &verified).passed(),
"{status:?} without results still cannot pass"
);
}
}

#[test]
fn selected_inputs_and_expectations_have_admission_ceilings() {
let mut p = plan();
Expand Down
Loading