Repository navigation
dream(evidence-and-gates): validate() rejects failed-to-start/unavailable receipts… - #5
Merged
Merged
Conversation
# Conflicts: # tests/core.rs
…eceipt rule PR #5 changes ExecutionReceipt::validate in src/evidence.rs, which left docs/diagrams/generated stale. Regenerated with CI's command (sealmap 0.4.0); a protected path, regenerated on the operator's direct instruction. Co-Authored-By: jjohare <github@thedreamlab.uk>
jjohare
marked this pull request as ready for review
November 14, 2026 17:26
Member
Author
|
Merged by the agent session on the operator's direct instruction (2026-11-14). Checks green on the head. Fixups: merge of main restoring a brace and #[test] the conflict hunk dropped (both PRs' tests kept; 27 core tests pass), and regenerated docs/diagrams/generated (protected) with CI's sealmap 0.4.0 command. No human review recorded; this merge is not review evidence (ADR-2190). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft PR opened by the dream engine on a GATED ACCEPT night (2026-11-13-visioncraft, run
5496cc8a5edd0e5d).Candidate tree
2dc10fd05a1b5d1703d9d2ccc38f8089a5ff21b4was applied in isolation and the required evaluators re-run against it: clippy=PASSED, fmt=PASSED, tests=PASSED, tests-core-only=PASSED. Witness77fdaad607b5.A human decides the merge — evaluation is not promotion.
Finding: Given
ExecutionReceipt::validate()only enforces the exit/signal mutual exclusion and the completed-requires-exit-code rule, when a receipt whose process status isfailed-to-startorunavailablealso records anexit_codeorsignal, thenvalidate()must reject it as inconsistent, while the same statuses with neither field remain valid nonpassing evidence.Gate: ACCEPT upheld: 4 required evaluator(s) passed on candidate tree 2dc10fd05a1b
Note: the engine ran
rustfmton the candidate's own files (src/evidence.rs, tests/core.rs) as a second commit; the logic is the model's, the layout the formatter's.