Skip to content

dream(evidence-and-gates): validate() rejects failed-to-start/unavailable receipts… - #5

Merged
jjohare merged 4 commits into
mainfrom
dream/evidence-and-gates-2026-11-13
Nov 14, 2026
Merged

jjohare merged 4 commits into
mainfrom
dream/evidence-and-gates-2026-11-13

Conversation

@jjohare

@jjohare jjohare commented Nov 13, 2026

Copy link
Copy Markdown
Member

Draft PR opened by the dream engine on a GATED ACCEPT night (2026-11-13-visioncraft, run 5496cc8a5edd0e5d).

Candidate tree 2dc10fd05a1b5d1703d9d2ccc38f8089a5ff21b4 was applied in isolation and the required evaluators re-run against it: clippy=PASSED, fmt=PASSED, tests=PASSED, tests-core-only=PASSED. Witness 77fdaad607b5.

A human decides the merge — evaluation is not promotion.

Finding: Given ExecutionReceipt::validate() only enforces the exit/signal mutual exclusion and the completed-requires-exit-code rule, when a receipt whose process status is failed-to-start or unavailable also records an exit_code or signal, then validate() must reject it as inconsistent, while the same statuses with neither field remain valid nonpassing evidence.

Gate: ACCEPT upheld: 4 required evaluator(s) passed on candidate tree 2dc10fd05a1b

Note: the engine ran rustfmt on the candidate's own files (src/evidence.rs, tests/core.rs) as a second commit; the logic is the model's, the layout the formatter's.

codex and others added 4 commits November 13, 2026 01:26
…eceipt rule

PR #5 changes ExecutionReceipt::validate in src/evidence.rs, which left
docs/diagrams/generated stale. Regenerated with CI's command (sealmap 0.4.0);
a protected path, regenerated on the operator's direct instruction.

Co-Authored-By: jjohare <github@thedreamlab.uk>
@jjohare
jjohare marked this pull request as ready for review November 14, 2026 17:26
@jjohare

jjohare commented Nov 14, 2026

Copy link
Copy Markdown
Member Author

Merged by the agent session on the operator's direct instruction (2026-11-14). Checks green on the head. Fixups: merge of main restoring a brace and #[test] the conflict hunk dropped (both PRs' tests kept; 27 core tests pass), and regenerated docs/diagrams/generated (protected) with CI's sealmap 0.4.0 command. No human review recorded; this merge is not review evidence (ADR-2190).

@jjohare
jjohare merged commit 6add68e into main Nov 14, 2026
3 checks passed
@jjohare
jjohare deleted the dream/evidence-and-gates-2026-11-13 branch November 14, 2026 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants