fix(loader): accept str paths in UMFLoader.save/load - #21
Merged
Merged
Conversation
save() annotated path: Path but never coerced it, so passing an f-string path died with 'str' object has no attribute 'mkdir'. Coerce on entry like load() already did and widen both signatures to str | Path. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Harvested from the parked
feat/databricks-notebook-dbt-defaultsbranch — the one change there that fixes code on current main.UMFLoader.save()annotatedpath: Pathbut never coerced it, so passing an f-string path died with'str' object has no attribute 'mkdir'. Coerce on entry likeload()already did, and widen both signatures tostr | Path.Loader test suite (79 tests) and format gate pass locally.
🤖 Generated with Claude Code