Skip to content

Install ddev non-editably in the setup-ddev action - #25325

Merged
lucia-sb merged 2 commits into
masterfrom
lucia-sb/setup-ddev-editable-input
Sep 24, 2026
Merged

lucia-sb merged 2 commits into
masterfrom
lucia-sb/setup-ddev-editable-input

Conversation

@lucia-sb

@lucia-sb lucia-sb commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

What does this PR do?

Makes the setup-ddev action install ddev and datadog_checks_dev as regular packages instead of editable ones when install-mode is local.

Motivation

An editable install only helps when the sources change after installing and you want those changes picked up, which never happens in CI and shouldn't. When a job does replace the checkout, an editable install silently switches to the new code. The Measure Disk Usage workflow in #25233 installs ddev from master and then checks out the commit it measures, so it needs the installed ddev to stay on master.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add qa/required if this PR needs QA validation, or qa/skip-qa if it does not. Exactly one of the two is required.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@lucia-sb lucia-sb added the qa/skip-qa Automatically skip this PR for the next QA label Sep 23, 2026
@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

evalya-impact-summary

evalya impact analysis
Impact analysis: RUN-ALL — every test task will run
Trigger:         empty diff (default branch, scheduled run, or shallow-clone fallback)
Test tasks:      0 (all selected)
Publish tasks:   2 (always emitted)
Diff:            empty (no diff information)

Learn more about CI impact filtering

@lucia-sb
lucia-sb marked this pull request as ready for review September 23, 2026 15:22
@lucia-sb
lucia-sb requested a review from a team as a code owner September 23, 2026 15:22

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fe7ddda79d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread .github/actions/setup-ddev/action.yml Outdated
@datadog-prod-us1-6

datadog-prod-us1-6 Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Tests  Code Coverage

✅ All CI checks and tests passed.

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 89.34% (+0.09%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 45258b8 | Docs | View more details | Give us feedback!

@AAraKKe AAraKKe left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good catch, I didn't remember this was an editable install which makes no sense btw. I would not add that option (editable only allow you to automatically get changes as they happen which is not going to happen, and should not happen in CI). I would remove the editable installation all together.

CI never edits the ddev sources after installing, so an editable install
only matters when a job replaces the checkout, where it runs the wrong code.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@lucia-sb lucia-sb changed the title Add an editable input to the setup-ddev action Install ddev non-editably in the setup-ddev action Sep 24, 2026
@dd-octo-sts

dd-octo-sts Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

Validation Report

All 21 validations passed.

Show details
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file ✅
ci Validate CI configuration and code coverage settings ✅
codeowners Validate every integration has a CODEOWNERS entry ✅
config Validate default configuration files against spec.yaml ✅
dep Verify dependency pins are consistent and Agent-compatible ✅
http Validate integrations use the HTTP wrapper correctly ✅
imports Validate check imports do not use deprecated modules ✅
integration-style Validate check code style conventions ✅
jmx-metrics Validate JMX metrics definition files and config ✅
labeler Validate PR labeler config matches integration directories ✅
legacy-signature Validate no integration uses the legacy Agent check signature ✅
license-headers Validate Python files have proper license headers ✅
licenses Validate third-party license attribution list ✅
metadata Validate metadata.csv metric definitions ✅
models Validate configuration data models match spec.yaml ✅
openmetrics Validate OpenMetrics integrations disable the metric limit ✅
package Validate Python package metadata and naming ✅
qa-label Validate the pull request declares whether it needs QA for the next Agent release ✅
readmes Validate README files have required sections ✅
saved-views Validate saved view JSON file structure and fields ✅
version Validate version consistency between package and changelog ✅

View full run

@lucia-sb
lucia-sb requested a review from AAraKKe September 24, 2026 08:39

@AAraKKe AAraKKe left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lucia-sb
lucia-sb added this pull request to the merge queue Sep 24, 2026
Merged via the queue into master with commit 20a3127 Sep 24, 2026
368 checks passed
@lucia-sb
lucia-sb deleted the lucia-sb/setup-ddev-editable-input branch September 24, 2026 08:56
@dd-octo-sts dd-octo-sts Bot added this to the 7.85.0 milestone Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

qa/skip-qa Automatically skip this PR for the next QA team/agent-integrations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants