Repository navigation
Install ddev non-editably in the setup-ddev action - #25325
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
evalya-impact-summaryevalya impact analysis |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fe7ddda79d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
✅ All CI checks and tests passed. 🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 45258b8 | Docs | View more details | Give us feedback! |
AAraKKe
left a comment
There was a problem hiding this comment.
Thanks, good catch, I didn't remember this was an editable install which makes no sense btw. I would not add that option (editable only allow you to automatically get changes as they happen which is not going to happen, and should not happen in CI). I would remove the editable installation all together.
CI never edits the ddev sources after installing, so an editable install only matters when a job replaces the checkout, where it runs the wrong code. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Validation ReportAll 21 validations passed. Show details
|
What does this PR do?
Makes the
setup-ddevaction installddevanddatadog_checks_devas regular packages instead of editable ones wheninstall-modeislocal.Motivation
An editable install only helps when the sources change after installing and you want those changes picked up, which never happens in CI and shouldn't. When a job does replace the checkout, an editable install silently switches to the new code. The Measure Disk Usage workflow in #25233 installs ddev from master and then checks out the commit it measures, so it needs the installed ddev to stay on master.
Review checklist (to be filled by reviewers)
qa/requiredif this PR needs QA validation, orqa/skip-qaif it does not. Exactly one of the two is required.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged🤖 Generated with Claude Code