Install ddev from master in the measure disk usage workflow - #25233
Merged
Merged
Conversation
Ensures a PR that modifies ddev or datadog_checks_dev doesn't affect the disk usage measurement itself.
This comment has been minimized.
This comment has been minimized.
evalya-impact-summaryevalya impact analysis |
Contributor
Disk usage changeCommit No integration or dependency changed size. |
Matches the existing core-temp pattern used elsewhere in this repo for pulling trusted content from master alongside an untrusted checkout, instead of mutating the primary checkout's working tree in place.
The job already fetches full history, so origin/master is available locally. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…commit Check out master, install ddev from it non-editably, then check out the commit to measure. setup-ddev gains an editable input so the install survives the checkout replacing its sources. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
1 of 3 tasks
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
Validation ReportAll 21 validations passed. Show details
|
nubtron
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes the "Measure Disk Usage" workflow to check out
masterfirst, install ddev from it, and only then check out the commit being measured.Depends on #25325, which makes
setup-ddevinstall ddev non-editably. Merge that one first: until it lands, the second checkout would replace the sources behind the editable install, and the measurement would run the measured commit's ddev.Motivation
The workflow checks out the PR's/push's
head_shaand then installs ddev "locally" from that same checkout. If a PR modifiesddevordatadog_checks_devitself, the disk-usage measurement would run using the modified tool rather than a known-good version, which can produce unreliable or misleading measurements. Installing ddev frommasterinstead decouples the measurement tool from the code being measured.Review checklist (to be filled by reviewers)
qa/requiredif this PR needs QA validation, orqa/skip-qaif it does not. Exactly one of the two is required.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged