Skip to content

Install ddev from master in the measure disk usage workflow - #25233

Merged
lucia-sb merged 8 commits into
masterfrom
claude/measure-disk-usage-workflow-94229c
Sep 24, 2026
Merged

lucia-sb merged 8 commits into
masterfrom
claude/measure-disk-usage-workflow-94229c

Conversation

@lucia-sb

@lucia-sb lucia-sb commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

What does this PR do?

Changes the "Measure Disk Usage" workflow to check out master first, install ddev from it, and only then check out the commit being measured.

Depends on #25325, which makes setup-ddev install ddev non-editably. Merge that one first: until it lands, the second checkout would replace the sources behind the editable install, and the measurement would run the measured commit's ddev.

Motivation

The workflow checks out the PR's/push's head_sha and then installs ddev "locally" from that same checkout. If a PR modifies ddev or datadog_checks_dev itself, the disk-usage measurement would run using the modified tool rather than a known-good version, which can produce unreliable or misleading measurements. Installing ddev from master instead decouples the measurement tool from the code being measured.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add qa/required if this PR needs QA validation, or qa/skip-qa if it does not. Exactly one of the two is required.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Ensures a PR that modifies ddev or datadog_checks_dev doesn't affect
the disk usage measurement itself.
@lucia-sb lucia-sb added the qa/skip-qa Automatically skip this PR for the next QA label Sep 16, 2026
@dd-octo-sts dd-octo-sts Bot added dev/testing dev/tooling and removed qa/skip-qa Automatically skip this PR for the next QA labels Sep 16, 2026
@datadog-datadog-prod-us1

This comment has been minimized.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

evalya-impact-summary

evalya impact analysis
Impact analysis: RUN-ALL — every test task will run
Trigger:         empty diff (default branch, scheduled run, or shallow-clone fallback)
Test tasks:      0 (all selected)
Publish tasks:   2 (always emitted)
Diff:            empty (no diff information)

Learn more about CI impact filtering

@dd-octo-sts

dd-octo-sts Bot commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

Disk usage change

Commit 61f695c compared against 1f98f39.

No integration or dependency changed size.

lucia-sb and others added 2 commits September 16, 2026 09:47
Matches the existing core-temp pattern used elsewhere in this repo for
pulling trusted content from master alongside an untrusted checkout,
instead of mutating the primary checkout's working tree in place.
The job already fetches full history, so origin/master is available locally.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@lucia-sb
lucia-sb marked this pull request as ready for review September 23, 2026 10:07
@lucia-sb
lucia-sb requested a review from a team as a code owner September 23, 2026 10:07
@lucia-sb lucia-sb added the qa/skip-qa Automatically skip this PR for the next QA label Sep 23, 2026
lucia-sb and others added 2 commits September 23, 2026 12:56
…commit

Check out master, install ddev from it non-editably, then check out the
commit to measure. setup-ddev gains an editable input so the install
survives the checkout replacing its sources.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
lucia-sb and others added 3 commits September 23, 2026 17:21
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@dd-octo-sts

dd-octo-sts Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

Validation Report

All 21 validations passed.

Show details
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file ✅
ci Validate CI configuration and code coverage settings ✅
codeowners Validate every integration has a CODEOWNERS entry ✅
config Validate default configuration files against spec.yaml ✅
dep Verify dependency pins are consistent and Agent-compatible ✅
http Validate integrations use the HTTP wrapper correctly ✅
imports Validate check imports do not use deprecated modules ✅
integration-style Validate check code style conventions ✅
jmx-metrics Validate JMX metrics definition files and config ✅
labeler Validate PR labeler config matches integration directories ✅
legacy-signature Validate no integration uses the legacy Agent check signature ✅
license-headers Validate Python files have proper license headers ✅
licenses Validate third-party license attribution list ✅
metadata Validate metadata.csv metric definitions ✅
models Validate configuration data models match spec.yaml ✅
openmetrics Validate OpenMetrics integrations disable the metric limit ✅
package Validate Python package metadata and naming ✅
qa-label Validate the pull request declares whether it needs QA for the next Agent release ✅
readmes Validate README files have required sections ✅
saved-views Validate saved view JSON file structure and fields ✅
version Validate version consistency between package and changelog ✅

View full run

@lucia-sb
lucia-sb added this pull request to the merge queue Sep 24, 2026
Merged via the queue into master with commit 3e38543 Sep 24, 2026
36 checks passed
@lucia-sb
lucia-sb deleted the claude/measure-disk-usage-workflow-94229c branch September 24, 2026 13:04
@dd-octo-sts dd-octo-sts Bot added this to the 7.85.0 milestone Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants