Skip to content

fix: escape the pmset table cell and isolate a package test from launchd - #69

Merged
scttbnsn merged 1 commit into
dev/m2from
fix/promotion-68-review
Nov 3, 2026
Merged

scttbnsn merged 1 commit into
dev/m2from
fix/promotion-68-review

Conversation

@scttbnsn

@scttbnsn scttbnsn commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Two findings from CodeRabbit's review of the beta.9 promotion (#68):

  • The README's closed-lid row had 0|1 inside a code span, and GitHub tables split on it, so the row rendered with a missing cell. It now reads 0 and 1.
  • updatePreparationUsesTheACGuardBeforeSavingTimers(package: true) built an AppModel without inertMigration, so prepareForPackage ran the real helper migration against launchd and SMAppService. The test now injects the inert migration. No other test that calls prepareForPackage was missing it.

@coderabbitai

coderabbitai Bot commented Nov 3, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 06745b30-4110-4c7f-96b3-6d3d9d41ca59

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.

@codecov

codecov Bot commented Nov 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@scttbnsn
scttbnsn merged commit c2e38c4 into dev/m2 Nov 3, 2026
3 of 4 checks passed
@scttbnsn
scttbnsn deleted the fix/promotion-68-review branch November 3, 2026 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant