You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
build(release): promote 1.0.0-beta.9 to main - #68
Promotes beta.9, build 14. This is the first build where closed-lid mode uses a narrow sudoers rule for pmset -a disablesleep 0|1 instead of a root helper.
* feat(support): add GitHub Sponsors and Donate links to menu, About, website and README
* docs(website): note the Chromium install for the social card renderer
…d release checks (#65)
* build(release): stop bundling the helper executable and keep only its migration plist
build-app.sh no longer copies or signs dilated-helper. package-release
now requires the helper LaunchDaemon plist (so SMAppService can unregister
the job older installs still have) and rejects a bundled executable.
smoke-test --expect-no-helper checks lid-permission status and the
deprecated helper status alias instead of the old helper setup path.
* feat(closed-lid)!: drop the privileged helper and make the sudo rule the only path
ClosedLidController always uses LocalClosedLidTransport and the
DilatedLocalClosedLidTransport flag is gone. Settings always shows the
PERMISSION group. dilated-helper, its XPC transport, SMAppService
registration and code identity check are deleted; dilated helper
status|setup|remove stay one release as deprecated lid-permission aliases.
At launch HelperMigration unregisters a leftover helper through
SMAppService, confirms launchd dropped the job, and reverts sleep through
the sudo path when the old helper left it off with no Dilated session
marker. It never blocks launch, and its result is saved for Settings
(with a Restore normal sleep action when the revert fails).
prepare-update and prepare-uninstall confirm sleep is back on before
quitting. prepare-uninstall removes the sudoers rule only with
--remove-lid-permission. Old helperWasApproved handoffs still decode and
are ignored.
* fix(closed-lid): retry helper migration at package prepare and surface leftovers on every launch
* docs(closed-lid): describe the sudo rule, add zap stanza and update acceptance checks
* test(closed-lid): use fixed safety readings in the package preparation test
…en it exits (#66)
The app now rewrites a small heartbeat file on the service tick while a closed-lid session is active. The watchdog reverts through the existing path when the file stops changing for the lease plus 30s on its own monotonic clock. A resumed app sees its marker gone and ends the session instead of re-enabling.
This release replaces the retired privileged helper with in-app closed-lid permission handling, heartbeat-based recovery, and launch-time helper migration. It also updates CLI flows, package and release checks, documentation, tests, and support-link presentation. Changes: Closed-Lid Control and Helper Migration
Layer / File(s)
Summary
Local service and heartbeat recovery Sources/DilatedCore/*, Sources/DilatedUI/ClosedLid/ClosedLidController.swift, Sources/DilatedUI/ClosedLid/LocalClosedLidTransport.swift, Tests/DilatedCoreTests/ClosedLidHeartbeatTests.swift, docs/ARCHITECTURE.md
The local service now writes heartbeats while a lease is active. The watchdog reads those heartbeats and reverts sleep prevention after a stall. The local transport starts ticking on demand.
The app checks the retired helper job, records migration results, and exposes dismiss or restore actions. The helper executable, installation flow, and XPC client are removed.
The control protocol adds optional sudo-rule removal during uninstall preparation. The CLI, app, automation, and settings paths now use closed-lid permission state. Package preparation now confirms closed-lid mode is off before it continues.
The bundle keeps the migration plist but omits the helper executable. Release validation, prerelease gates, and version metadata move to beta.9 build 14. The installation and release docs describe the new sudo-rule workflow.
Support links .github/FUNDING.yml, README.md, Sources/DilatedUI/SupportLinks.swift, Sources/DilatedUI/Menu/AwakeMenu.swift, Sources/DilatedUI/Settings/AboutSettings.swift, Tests/DilatedUITests/AboutSettingsTests.swift, Tests/DilatedUITests/MenuTests.swift, website/e2e/site.spec.mjs
The app adds sponsor and donation destinations to its Support menu and About credits. Tests check the links and the footer layout on the website.
CodesWhat/dilated#23: It hardens helper removal, which this PR replaces with the HelperMigration flow.
CodesWhat/dilated#57: It introduces the sudo-rule foundation and local transport changes that this PR builds on.
CodesWhat/dilated#63: It adds the closed-lid permission model and local transport that this PR extends.
Suggested reviewers:biggest-littlest
Merge Risk: Moderate · previous review 74c60
A successfully prepared update or uninstall can remain blocked waiting for Dilated to exit. Arm the fallback before requesting termination.
Pre-merge checks: 4 · 1
Failed checks: 1 warning
Check name
Status
Explanation
Resolution
Docstring Coverage
Docstring coverage is 16.13% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documenta…
Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed checks: 4 passed
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly identifies the release build and promotion of version 1.0.0-beta.9 to main, which matches the pull request objectives and changes.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
Docstring coverage is 16.13% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 93 functions across 54 files. (1 skipped: 1 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Files skipped from review as they are similar to previous changes: 1
README.md
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
…ate (#70)
NSWindow.endSheet leaves the SwiftUI presentation state set, so the shortcut recorder sheet came straight back and prepare-update never finished quitting. Rebuild the settings page to clear sheet state, end any nested sheets, abort app-modal alerts, and exit the process if terminate hasn't completed within 5s of a successful prepare.
…k and arm forced exit before terminate (#71)
The heartbeat tests relied on real wall-clock lease and poll intervals and
flaked on a loaded runner. The watchdog now takes a monotonic clock and a
poll ticker (defaults unchanged), so tests advance time and heartbeats in
lockstep. PackageQuit schedules its forced exit before calling terminate(),
which may not return under terminateLater.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Promotes beta.9, build 14. This is the first build where closed-lid mode uses a narrow sudoers rule for
pmset -a disablesleep 0|1instead of a root helper.dilated lid-permission install. A session marker and relaunch revert, plus a detached watchdog, restore sleep if Dilated exits or stops responding. The old helper is unregistered on first launch, and Amphetamine-style rules are recognized. Hardware runs on macOS 27.2 covered install, remove, and kill -9 recovery in about 1s (feat(closed-lid): install, detect and remove the pmset sudo rule #58, feat(closed-lid): crash revert, permission settings and CLI for the sudo rule #60, feat(closed-lid): replace the root helper with the sudo rule, docs and release checks #65, fix(closed-lid): restore sleep when Dilated stops responding #66).Every PR passed CI on macOS 26. Packaging, notarization and the attended acceptance run on the signed build follow the tag.
Summary by CodeRabbit