Repository navigation
Conversation
About Dilated now opens a Settings page with the version, copyright, update check and project links instead of the stock panel.
Polling waits and the XPC deadline check used bounds that a loaded runner with coverage on can blow through. Polls still exit as soon as the condition holds, so passing runs aren't slower.
Add Playwright checks for the menu preview, layout, page controls and release metadata, served with the CSP from vercel.json, as a step in the verify job.
* build(release): prepare 1.0.0-beta.8, build 13 * build(deps): update Sparkle to 2.10.1
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 18 minutes. View limit details
 |
| Layer / File(s) | Summary |
|---|---|
About content and metadata Sources/DilatedUI/Settings/AboutSettings.swift, packaging/Info.plist, Tests/DilatedUITests/AboutSettingsTests.swift |
The About page displays app metadata, updater status, and project links. Bundle metadata and copyright use fallback values when needed. |
About navigation and menu integration Sources/DilatedUI/Settings/SettingsWindow.swift, Sources/DilatedUI/Menu/*, Sources/DilatedUI/ApplicationDelegate.swift, Tests/DilatedUITests/AboutSettingsTests.swift |
Settings navigation can select the About page. The menu’s About action presents that page. Tests cover navigation and the menu callback. |
Beta 8 release and website
| Layer / File(s) | Summary |
|---|---|
Beta 8 release metadata and links Package.swift, README.md, docs/INSTALLATION.md, docs/THIRD-PARTY.md, packaging/ReleaseNotes.txt, packaging/Version.plist, website/README.md, website/vercel.json |
Release references change to beta.8 and build 13. Sparkle changes to 2.10.1, and website download redirects point to beta.8 assets. |
Browser-check harness and CI wiring website/package.json, website/playwright.config.mjs, website/e2e/serve.mjs, scripts/verify-website-browsers.sh, .github/workflows/ci.yml, .gitignore, website/README.md |
Playwright checks run in Chromium, Firefox, and WebKit against a local server. CI runs the checks and configures a Codecov upload. |
Website behavior and publishing checks website/e2e/site.spec.mjs, website/tests/security.test.mjs, website/vercel.json, Tests/ReleaseTests/test_publish_website.py |
Browser tests cover layouts, menu behavior, page controls, and release metadata. Security checks validate the security.txt content and route. A publishing test checks that staging includes a committed dotfile. |
Coverage and test verification
| Layer / File(s) | Summary |
|---|---|
Swift coverage collection and export scripts/verify.sh, scripts/coverage-lcov.sh, README.md |
When enabled, verification saves Swift coverage profiles and exports a filtered LCOV report. The README adds a Codecov badge. |
Editor inspection and asynchronous test deadlines Sources/DilatedUI/Automation/TriggersSettings.swift, Tests/DilatedUITests/MountedSettingsTests.swift, Tests/DilatedCoreTests/PackageHelperTests.swift, Tests/DilatedUITests/ActivityInputTests.swift, Tests/DilatedUITests/ClosedLidControllerTests.swift, Tests/DilatedUITests/DownloadTests.swift, Tests/DilatedUITests/FeedbackTests.swift |
Debug-only callbacks support mounted process-picker inspection. Several test deadlines and disk-image command timeouts increase. |
Local commit checks
| Layer / File(s) | Summary |
|---|---|
Commit hooks and contributor instructions lefthook.yml, scripts/check-commit-msg.sh, README.md |
Lefthook runs staged-file checks and a commit-message validator. The README adds hook setup instructions and a Star History link. |
Estimated code review effort: 3 (Moderate) | ~25 minutes
Change: Other
Sequence Diagram(s)
sequenceDiagram
participant AwakeMenu
participant ApplicationDelegate
participant SettingsWindow
participant SettingsContent
participant AboutSettings
AwakeMenu->>ApplicationDelegate: Invoke About callback
ApplicationDelegate->>SettingsWindow: Present About page
SettingsWindow->>SettingsContent: Pass requested page
SettingsContent->>AboutSettings: Render selected page
sequenceDiagram
participant Playwright
participant PlaywrightConfig
participant StaticServer
participant WebsiteDist
PlaywrightConfig->>StaticServer: Start local server
Playwright->>StaticServer: Request website pages and metadata
StaticServer->>WebsiteDist: Read files from dist
StaticServer-->>Playwright: Return page responses
Possibly related PRs
- CodesWhat/dilated#42: Promotes beta.7; this change advances the same release process to beta.8.
- CodesWhat/dilated#10: Changes the website menu preview that the new browser tests exercise.
- CodesWhat/dilated#15: Fixes process-picker loading; this change adds a mounted test for the picker.
Suggested reviewers: biggest-littlest
Merge Risk: 
41358
-
The new About page wiring may not compile because the settings window initializer reads a property before its superclass is initialized. Confirm the app builds, or apply the small initializer change, before merging. The commit hook and CI shell syntax checks skip every script after the first, and coverage export can fail in a symlinked checkout. These are smaller follow-ups.
Pre-merge checks: 
-
Check name Status Explanation Resolution Docstring Coverage Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Write docstrings for the functions missing them to satisfy the coverage threshold. -
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly and concisely identifies the primary change: promoting release 1.0.0-beta.8 to the main branch. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 20 functions across 23 files. (12 skipped: 12 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
-
Finishing Touches
-
Generate docstrings
-
- Commit to this branch
- Create a new PR
Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
- fix(ci): run bash -n per file in verify.sh and the Lefthook hook; it only parsed the first file - fix(hooks): allow git's amend! autosquash subjects - fix(ci): resolve symlinks before filtering coverage paths - test(core): keep the package-check child alive past the 30s poll - docs(readme): point the coverage badge at main
biggest-littlest
approved these changes
Nov 2, 2026
biggest-littlest
left a comment
biggest-littlest
left a comment
Member
There was a problem hiding this comment.
Reviewed the promotion diff and the fixes from CodeRabbit's first pass. CI is green on 8a66728.
This was referenced Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes beta.8, build 13, from dev/m2 to main. It adds an About page in Settings and moves Sparkle to 2.10.1.
Also in this promotion: the process picker test fix, Codecov upload and badge, security.txt on the site, Lefthook commit checks, wider waits in the time-based tests, and the website checks in Chromium, Firefox and WebKit (#43 to #52). Every one of those PRs passed CI on dev/m2. Packaging and notarization follow from the signed tag once this is merged.
Summary by CodeRabbit