Repository navigation
fix(ci): check every shell script and accept amend! commits - #55
Merged
Merged
Conversation
- fix(ci): run bash -n per file in verify.sh and the Lefthook hook; it only parsed the first file - fix(hooks): allow git's amend! autosquash subjects - fix(ci): resolve symlinks before filtering coverage paths - test(core): keep the package-check child alive past the 30s poll - docs(readme): point the coverage badge at main
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
 |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from CodeRabbit's review of the beta.8 promotion (#54).
bash -n a b conly parsesaand passes the rest as arguments, so verify.sh and the Lefthook shell check were skipping every script after the first. Both now loop. The commit-msg hook also acceptsamend!subjects, the coverage filter resolves symlinks before comparing paths, the package-check test's child process outlives the 30s poll, and the coverage badge points at main.All scripts pass
bash -none at a time, the hook acceptsamend!and still rejects a bad subject, and PackageHelperTests passes.