Skip to content

Correct local Postgres diagnostics and help - #509

Open
sdairs wants to merge 1 commit into
issue-464-postgres-start-rollbackfrom
issue-465-postgres-diagnostics-help
Open

Correct local Postgres diagnostics and help#509
sdairs wants to merge 1 commit into
issue-464-postgres-start-rollbackfrom
issue-465-postgres-diagnostics-help

Conversation

@sdairs

@sdairs sdairs commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Route local Postgres validation and runtime failures through dedicated errors so they never report a ClickHouse execution failure.
  • Honor DOCKER_HOST endpoint selection and give constructor and ping failures platform-aware Docker Desktop or Engine, socket permission, context, and rootless guidance.
  • Correct start help for the versioned data path, all five managed labels, and omitted versus explicit port behavior.
  • Add exact help snapshots plus subprocess fake-Docker coverage for missing sockets, permission failures, daemon-down responses, and missing psql.

Tests

  • cargo test -p clickhousectl (768 passed)
  • cargo test -p clickhousectl --test local_postgres_diagnostics_test (4 passed)
  • cargo test -p clickhousectl --test local_postgres_help_test (2 passed)
  • cargo test -p clickhousectl --test local_postgres_preflight_test (2 passed)
  • cargo fmt --all --check
  • cargo clippy -p clickhousectl --all-targets -- -D warnings
  • cargo build -p clickhousectl

Stack

Position 4 of 4 (top), based on #501.

Closes #465

Stack created with GitHub Stacks CLIGive Feedback

@sdairs sdairs changed the title issue 465 postgres diagnostics help Correct local Postgres diagnostics and help Aug 24, 2026
@sdairs
sdairs force-pushed the issue-465-postgres-diagnostics-help branch from e44f127 to f4e78c4 Compare August 25, 2026 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Correct local Postgres diagnostics and help

1 participant