Disable telemetry in standalone local integration scripts - #511
Open
sdairs wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DO_NOT_TRACK=1at the standalone Postgres integration script boundary before it invokesclickhousectl.DO_NOT_TRACK=0, runs the script against fake CLI/Docker/jq executables, and proves every spawned CLI inheritsDO_NOT_TRACK=1.Audit
scripts/test-postgres-integration.shis the only executable repository integration/evaluation script that invokesclickhousectl; it is now protected at its own boundary.scripts/check-openapi-drift.pyinvokes the Rust analyzer, notclickhousectl; the otherscripts/*.pyfiles do not launch the CLI.install.shinstalls the binary without executing it.npm/bin/cli.jsis the user-facing product shim, not a repository test boundary, so it intentionally preserves user telemetry choices.DO_NOT_TRACK=1; no workflow change is needed.Tests
python3 -m unittest discover -s scripts/tests(44 passed)python3 -m unittest scripts.tests.test_script_telemetry(1 passed)bash -n scripts/test-postgres-integration.shshellcheck scripts/test-postgres-integration.shcargo test -p clickhousectl(768 passed)cargo test -p clickhousectl --test telemetry_test(21 passed)cargo clippy -p clickhousectl --all-targets -- -D warningscargo fmt --all --checklocal postgres edge casesCI check covers it.Stack
Position 5 of 5 (top), based on #509.
Closes #458
Stack created with GitHub Stacks CLI • Give Feedback