Skip to content

fix: prod finalize/rollback without a second approval (production-ops) #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
saqibmanan wants to merge 1 commit into from
Closed

fix: prod finalize/rollback without a second approval (production-ops) #182

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/deploy-backend.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,9 @@ jobs:
${{ !cancelled() && needs.deploy.result == 'success' &&
(needs.smoke-tests.result == 'failure' || needs.functional-tests.result == 'failure') }}
runs-on: ubuntu-latest
environment: ${{ github.ref_name == 'main' && 'production' || 'development' }}
# production-ops: same prod host/SSH secrets, no required reviewer, main-only.
# The human approval is on the deploy job; finalize/rollback must not wait.
environment: ${{ github.ref_name == 'main' && 'production-ops' || 'development' }}
# 50m: must comfortably exceed the Restore previous image step's own
# 40m command_timeout (see the Deploy job's equivalent step for why).
timeout-minutes: 50
Expand Down Expand Up @@ -386,7 +388,9 @@ jobs:
needs.smoke-tests.result == 'success' &&
(needs.functional-tests.result == 'success' || needs.functional-tests.result == 'skipped') }}
runs-on: ubuntu-latest
environment: ${{ github.ref_name == 'main' && 'production' || 'development' }}
# production-ops: same prod host/SSH secrets, no required reviewer, main-only.
# The human approval is on the deploy job; finalize/rollback must not wait.
environment: ${{ github.ref_name == 'main' && 'production-ops' || 'development' }}
timeout-minutes: 10
steps:
- name: Checkout code
Expand Down
Loading