fix: prod finalize/rollback without a second approval (production-ops) - #182
Closed
saqibmanan wants to merge 1 commit into
Closed
saqibmanan wants to merge 1 commit into
saqibmanan wants to merge 1 commit into
Conversation
…pproval production requires a reviewer, and every job referencing it asked again: approve the deploy, then approve finalize or rollback -- so a failing prod deploy stayed live until someone clicked. production-ops holds the same host and SSH secrets with no reviewer and a main-only branch policy; the human approval stays on the deploy job.
Contributor
Author
|
Closing — decided to keep a single production environment with two approvals; production-ops not needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Production required a reviewer, and every job referencing it asked again — deploy, then finalize or rollback — so a failing prod deploy stayed live until someone clicked.
production-ops(created on this repo) holds the same host var and SSH secrets, no reviewer, main-only branch policy. Prod finalize/rollback now use it; the single human approval stays on the deploy job. Dev behaviour unchanged (developmentno longer needs approval and is restricted todev).Merge only after EC2_USERNAME and EC2_PRIVATE_KEY are set on production-ops, or prod finalize/rollback lose their SSH credentials.