Reconcile uncertain personal plan operations before retry - #2880
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Owner
Author
|
Independent bounded Luna review is CLEAN, including the source/account generation guards and the scoped automatic-write-retry opt-out. No HIGH/CRITICAL defect found. Final local proving evidence and limitations are in the PR body. |
This was referenced Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Personal-plan writes now require explicit refresh after an uncertain response: cached entries and last-worked metadata retract, controls stay blocked, and the error identifies the attempted plan change or Focus. The API wrappers opt out of automatic write retries, so a response lost after commit produces one write and a deliberate reconciliation. Same-account reads coalesce safely across Home consumers; account transitions cannot reuse or clear the wrong pending request. Empty Focus targets return validation errors without changing saved state.
Continues #2808, stacked on #2866. This reduces recovery friction and preserves private plan state without changing board cards or deadlines. Accepted-navigation Focus timing remains separate follow-through.
Verification: full backend 9,188 passed/34 existing skips; full frontend 6,380 passed/3 existing skips across 412 files; ten focused store cases, typecheck/production build, scoped ESLint and documentation links/governance/diff pass. Two real-API Chromium journeys pass in 27.3 seconds: rejected Focus, saved edit with lost response, no automatic second write, explicit refresh reconciliation, successful plan/Focus/Classic resume and mobile accessibility. The initial browser failure exposed the inherited PUT retry and is retained as evidence; the final opt-out repairs that cause. One bounded independent Luna review is CLEAN.
Temporary services are stopped; only a synthetic database was used. Physical devices, production deployment and existing OUTSTANDING_TASKS.md owner choices remain unverified/unchanged. Preserve the integration base branch, then retarget and qualify against main after it lands.