Record personal Focus after accepted navigation - #2881
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Owner
Author
|
Independent bounded Luna review is CLEAN. Exact-route/account checks precede Focus recording and no save completion navigates again. Local checks and remaining limits are recorded in the PR body. |
This was referenced Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Home Resume and the personal plan now share a Focus navigation path that records last-worked only after the router accepts the exact destination for the same account. Aborted navigation and login redirects leave history unchanged, and a delayed save never redirects the user back after they leave. A failed history save is explained on the thinking page with a link to refresh the personal plan.
Continues #2808; stacked on #2880. No backend code, card state or deadlines change.
Verification: full frontend 6,386 passed/3 existing skips across 413 files; sixteen targeted real memory-router/store cases; production build/typecheck, scoped ESLint, documentation links/governance/diff pass. Two real-API Chromium journeys pass in 21.5 seconds, including failed-history recovery and successful Classic/other-experience resume. One bounded independent Luna review is CLEAN. The initial unmount fixture destroyed the whole router application; the corrected fixture retains the app while disposing its child, matching production lifecycle.
Browser logs exposed an existing empty-board read from the thinking-route watcher while leaving. It has no navigation/mutation effect and is tracked as bounded #2808 follow-through. Temporary services are stopped; only synthetic data was used. Physical-device/release acceptance and existing OUTSTANDING_TASKS.md human choices remain separate. Preserve stack bases, then retarget and qualify against main after they land.