Cancel board preview results immediately on close - #2874
Merged
Chris0Jeky merged 1 commit intoSep 10, 2026
Merged
Conversation
Owner
Author
|
Independent bounded Luna review of the close-only diff over b262c8e completed CLEAN for HIGH/CRITICAL. clear() increments the generation before close is emitted, so a delayed result cannot republish markers while route removal is pending. Root observed13component tests, typecheck, scopedESLint and diff checks passing. This resolves the tracked MEDIUM close-during-load follow-through from #2872; no backend/board mutation is introduced. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Base automatically changed from
codex/2808-board-proposal-overlays
to
codex/2808-overhaul-integration
September 10, 2026 02:42
Chris0Jeky
merged commit Sep 10, 2026
d332434
into
codex/2808-overhaul-integration
34 of 35 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing a board proposal preview now clears its displayed markers and invalidates pending requests synchronously, before the route finishes removing the preview. A delayed response cannot repaint proposed changes after Close.
This addresses the tracked MEDIUM close-during-load finding from #2872 and continues #2808. Stacked on #2872; keep its base branch until it lands.
Verification: 13 BoardProposalPreview component tests pass, including displayed and pending-response close cases with delayed route removal. Typecheck, scoped ESLint and diff checks pass. The parent PR already proves the board journey across four experiences and both renderers; no board mutation or backend behavior changes here. OUTSTANDING_TASKS.md human decisions remain unchanged.