Preserve planning dates and resume Focus from Classic Home - #2876
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Independent bounded Luna review CLEAN forHIGH/CRITICAL. Calendar formatting/localToday/tomorrow and Classicboth-renderer resume are correct. MEDIUM overlapping plan loads on rapid Home switches is tracked with broader plan loading/failure-metadata follow-through under#2808; generation guards prevent stale state. Root observed6373frontendpasses/3skips,typecheck/build,25focusedtests,and17.6srealbrowserjourney. No extra review loop or speculative changes. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2526e4503c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| <template> | ||
| <OverhaulWorkspaceHome v-if="overhaulActivated" v-show="layout.experience !== 'classic'" /> | ||
| <PersonalPlanResume v-if="layout.experience === 'classic'" /> |
There was a problem hiding this comment.
When the selected locale is Italian or Spanish and Classic Paper/Grove is active, PaperHomeView renders translated Home copy but this newly inserted PersonalPlanResume renders hard-coded English strings such as “Resume focus” and “Your personal plan.” This makes the supported localized Home surface mixed-language; route the component's copy through the locale catalogs before mounting it in Classic Home.
Useful? React with 👍 / 👎.
|
|
||
| <template> | ||
| <OverhaulWorkspaceHome v-if="overhaulActivated" v-show="layout.experience !== 'classic'" /> | ||
| <PersonalPlanResume v-if="layout.experience === 'classic'" /> |
There was a problem hiding this comment.
When a last-worked card is available, PersonalPlanResume emits an <h2> for its title, but this insertion places it before the <h1> supplied by either Classic renderer. Users navigating by headings therefore encounter a subsection heading before the page title in both Paper/Grove and Legacy; mount the panel after the active renderer's Home heading or otherwise preserve an h1-first hierarchy.
Useful? React with 👍 / 👎.
a9f39fb
into
codex/2808-overhaul-integration
1 participant
Classic Home now offers the shared private Focus resume in both Grove/Paper and Legacy, so switching experiences retains a way back to saved thinking. The personal plan uses existing calendar-day helpers for displayed card deadlines and local Today/tomorrow controls; a midnight-UTC deadline no longer appears one day earlier in western time zones.
Continues #2808; stacked on #2874. Card deadlines and board data are unchanged.
Verification:6373frontend tests pass,3existing skips,412files;25focused Home/date/store tests;typecheck,productionbuild,scopedESLint,doclinks/governance/diffpass. The extended real-API Chromium journey runs in America/Los_Angeles:dueOctober20 staysOctober20,Today uses the local day,saved thinking resumes from Classicgrove/off,and existing4experience,List/Board/Horizon,MakeRoom,375px/axe/unchangedcard checks pass (17.6s). Narrow screenshot inspected. Synthetic DB only;5220/5320stopped.
Initial typecheck caught a remaining Today call to the removed helper, and the new Today browser locator initially matched navigation too. Both corrected; failing evidence retained. Independent bounded Luna review found noHIGH/CRITICAL. MEDIUM load-coalescing follow-through: rapidly switching an already-mounted Home can overlap plan refreshes from the shared continuation components; the store generation guard prevents stale results. Track with the remaining plan loading/failure-metadata work under #2808, without expanding this slice.
No backend changes or physical-device/production acceptance claim. Existing OUTSTANDING_TASKS.md owner decisions remain unchanged. Evidence: C:/Taskdeck-overhaul/evidence/plan-calendar-*.