Retry transient Windows launcher cleanup failures

[Chris0Jeky]

The Windows launcher can retain PID state after one transient StartTime read failure or one state-file lock. Retry Unknown identity reads for up to one second, requiring a fresh Match before termination, and retry state removal only after process exit and port release are proved. Persistent uncertainty and PID reuse still fail closed.

Verification:

• Real synthetic launcher baselines reproduced pre-kill Unknown and exclusive PID-file-lock failures. The existing post-kill Unknown control passed.
• Six focused cases pass, including persistent Unknown, repeated file locks, post-kill Unknown, and PID-reuse protection. Independent Terra high review: no HIGH/CRITICAL blocker.
• Full launcher run: 96 passed, 2 skipped, 2 cancelled in 460.6s. The unchanged Bash identity-test parent exceeded its30s budget, cancelling its duplicate subcase. Its test block and Bash launcher match the base; one isolated diagnostic run passed all4 cases in15.5s. The broad run remains incomplete evidence; timeout tracked under Frontend Unit (windows-latest) times out on slow runners: dev-up.test.mjs PowerShell spawns hit ETIMEDOUT and the job hits its timeout #2378.
• git diff --check passed. Hosted qualification is still required.

The probes establish both cleanup mechanisms, not which caused each historical failure. Maintainer review remains required because regression coverage touches scripts/ci. No release or repository settings change.

Refs #2561.

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-09-09T22:44:58.308150Z	190251b	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[Chris0Jeky]

Independent Terra high review: SHIP, no causal HIGH/CRITICAL blocker. Only fresh Match authorizes taskkill; persistent Unknown and PID reuse fail closed; state removal remains gated by process exit and port proof. Reviewer ran no tests. Root focused6pass and isolatedBash4pass; broad96pass/2skip/2cancelled remains documented and tracked under #2378. All five logs were copied and hash-verified into .claude/local/milestone-20260909/preserved-2561-cleanup/.tmp/issue-2561 before plain worktree removal. Source branch190251b84 is pushed. Hosted qualification and maintainer review are still required.