Keep one discard confirmation during board navigation - #2839
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Final verification and cleanup completed at d62d5e2:
Required hosted run34384444663 is pending. This is not yet a merge-ready or full #2090 completion claim. |
|
This source head is preserved unchanged in integration PR #2840 (f6a2bc9), together with #2836, #2838 and #2839. Each complete changed subtree matches its reviewed source exactly; composition review is SHIP. Source runs 34382773101 and 34383468694 failed before browser execution because Google's Chrome APT index had a Hash Sum mismatch. The integration's own required hosted gate must pass before merge. This source PR remains open until verified integration delivery; its owning issue is not automatically closed. |
|
The failed E2E job stopped before tests because Google's Chrome APT index had a Hash Sum mismatch. At 2026-09-09T18:10:42Z, a fresh read of InRelease and Packages.gz returned matching SHA256 233e56de019b57db89238fa7bcc3647718dbbea3a40c2dc1c633a8c8952aa9e9 (1405 bytes). Evidence is in .claude/local/milestone-20260909/apt-index-probe. This establishes the upstream index is now consistent at the observed endpoint; it is not a passing APT or browser check. With source head and main unchanged, the coordinator requested one failed-job-only retry of this PR's required run. Normal APT integrity checks remain intact. The combined integration2840 separately has an unresolved transcript-source review finding; this source subtree is independent and its original qualifying gate remains required. |
A dirty card's close confirmation could overlap the board's route-leave confirmation. Give the parent confirmation ownership while navigation or card switching is pending: suppress the child prompt and Escape handler, preserve the draft when the user cancels, and resolve the intended navigation once on confirmation. Skip focus restoration into the departing board.
Refs #2090. Ordinary card close and the existing save/delete navigation outcomes remain covered.
Validation at d62d5e2, base edf654e:
Required hosted CI remains pending. No backend/full-provider/deployment claim. Existing dynamic-import build warning and inactive API console noise are recorded separately from passing results. Canonical STATUS/MASTERPLAN/TESTING_GUIDE and OUTSTANDING_TASKS.md are unchanged. Raw evidence will be preserved before plain worktree removal.