Preserve raw source fidelity in linked transcript corrections - #2836
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Independent review completed in two rounds: first review found the raw-length HIGH at7cd816367; final fix verification at0ed072629 is SHIP, with no new HIGH/CRITICAL. Validation now rejects oversized raw CRLF text before normalization/transaction, matching the immutable source asset cap. Regressions cover unchanged persisted state on rejection and exact-cap acceptance. Final base merge changes no backend files. The full backend run exited0 (session11558). The preserved receipt reports9,116 passed/5 skipped; actual retained terminal chunks include API2,914/4 skips, CLI243, Architecture28/1 skip and Integration36. Domain1,637 and Application4,258 were reported from the worker's initial stream; their raw initial chunks are not in the durable log. Focused API7/Application73 raw logs are retained. No rerun was performed merely to reconstruct logging. All five local evidence files were copied and SHA-256 verified under |
|
This source head is preserved unchanged in integration PR #2840 (f6a2bc9), together with #2836, #2838 and #2839. Each complete changed subtree matches its reviewed source exactly; composition review is SHIP. Source runs 34382773101 and 34383468694 failed before browser execution because Google's Chrome APT index had a Hash Sum mismatch. The integration's own required hosted gate must pass before merge. This source PR remains open until verified integration delivery; its owning issue is not automatically closed. |
Linked transcript corrections previously passed normalized text into the immutable source asset, losing submitted CRLF/lone-CR fidelity, and title-only corrections appended a redundant source revision. Preserve the submitted text for genuine text corrections while keeping canonical transcript and queue payload normalized. Retitle without appending source text when content is unchanged.
Reject raw submissions above the existing 200,000-character limit before opening a transaction. Preserve claims-derived ownership, immutable prior source assets, queue compare-and-swap rollback, and explicit triage.
Refs #1999. This does not change old triage-stamp policy or close the broader issue.
Validation:
dotnet test backend/Taskdeck.sln -c Release -m:1, exit 0, 9,116 passed and 5 skipped at 0ed0726. Final head 0f498e2 incorporates main afadf72; backend files are byte-identical to the tested and reviewed head. Required hosted CI remains pending.Canonical STATUS/MASTERPLAN/TESTING_GUIDE remain with the existing coordinator. OUTSTANDING_TASKS.md human decisions are unchanged. Synthetic fixtures only; no live-provider or private-data claim.