Skip to content

Retire the unused shortcut dispatcher - #2819

Merged
Chris0Jeky merged 4 commits into
mainfrom
issue-2007/shortcut-dispatcher-retirement
Sep 9, 2026
Merged

Retire the unused shortcut dispatcher#2819
Chris0Jeky merged 4 commits into
mainfrom
issue-2007/shortcut-dispatcher-retirement

Conversation

@Chris0Jeky

@Chris0Jeky Chris0Jeky commented Sep 9, 2026

Copy link
Copy Markdown
Owner

Remove the unused shortcut-context dispatcher and its tests. Live shortcut handlers and help surfaces already use the shared registry; this closes the remaining dead-system acceptance item under the recorded D-5(e/f) ruling and removes the stale v0.4 analysis pointer. This reduces maintenance overhead without changing review-first behavior.

Closes #2007.

Validation: no remaining frontend references; 69 focused shortcut tests, typecheck, build, full frontend suite (390 files, 6204 passed, 3 skipped), docs governance and doc links (670 files) passed at implementation commit e033223. After merging main at 64508d3, the combined shortcut/palette tests passed (83 tests) and typecheck passed at a60397d. Full suite was not repeated for that disjoint reviewed palette addition; hosted CI will validate the combined head.

Existing acceptance evidence: PR #2615 delivered registry truth checks, non-overlapping chip tracks and one reachable help surface per skin. The current registry contains the flag-gated newAutomation row, Paper D/Space rows and bare T without G T, covered by shortcutLedgerTruth and help-surface tests. Live #1276/#2236 scope pointers are reconciled with D-5.

The closeout coordinator added a separate factual STATUS/MASTERPLAN/batch-record commit at b711b2a after integration #2815 landed. The dispatcher deletion is unchanged from its source review; current-base shortcut/ledger/notation/palette tests pass 36/36 and docs links/governance pass. Fresh Terra base-interaction review is clear. Final current-head hosted CI remains required. OUTSTANDING_TASKS.md is unchanged by this PR; no human acceptance or release decision is inferred.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-09T11:06:13.395716Z b711b2a New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Chris0Jeky

Copy link
Copy Markdown
Owner Author

Independent Terra high review at a60397d against 64508d3: SHIP, no confirmed HIGH/CRITICAL defect. The deleted composable has no application consumers; only its own tests are removed, and the historical pointer matches D-5(e/f).

LOW triage: the analysis file retains its older Last Updated metadata. Declined as non-blocking historical metadata; no fix commit. OUTSTANDING_TASKS.md remains unchanged and does not imply #1276 or any human action is complete.

@Chris0Jeky

Copy link
Copy Markdown
Owner Author

The existing-PR integration #2815 has landed at 22029c7. This final newly arrived PR is the remaining runtime candidate after the integration cutoff. I am refreshing it onto that main, checking only the new-base interaction with the deleted unused dispatcher, and retaining the recorded source review. Please hold further source/base changes or merges while its final qualification completes.

@Chris0Jeky

Copy link
Copy Markdown
Owner Author

Final coordinator head b711b2a includes the unchanged dispatcher-deletion patch plus a separate factual STATUS/MASTERPLAN/closeout record of merged #2815. Fresh Terra base review confirms no runtime consumers; current-base shortcut/ledger/notation/palette tests pass36/36, docs links672/governance/diffcheck pass. No new executable or authority change follows the reviewed deletion. This is the final qualification head; coordinator owns merge and closeout. Source runtime review remains applicable and current-head hosted CI is required.

@Chris0Jeky
Chris0Jeky merged commit 843a8f6 into main Sep 9, 2026
37 checks passed
@Chris0Jeky
Chris0Jeky deleted the issue-2007/shortcut-dispatcher-retirement branch September 9, 2026 11:29
@github-project-automation github-project-automation Bot moved this from Review to Done in Taskdeck Execution Sep 9, 2026
@Chris0Jeky

Copy link
Copy Markdown
Owner Author

Source-worker cleanup after delivery: the original codex-2007-shortcut-dispatcher-retirement worktree was removed with plain git worktree remove. Its local a60397d head is an ancestor of merged main843a8f6cb; tracked status was clean, and ignored inventory contained only generated frontend dist/ and node_modules/. No unique runtime data needed copying. Branch refs and the milestone coordinator's local CHECKPOINT.md retain the source/verification record. Primary checkout and unrelated worktrees are preserved. Final qualification/merge credit remains with the existing-PR coordinator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Keystroke ledger documents shortcuts that don't exist, omits ones that do, and there are three divergent shortcut systems

1 participant