Skip to content

test(verify): scope static-screen crash expectations by platform #2949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
AasishDairelSahayaGrinspan wants to merge 2 commits into
base: main
Choose a base branch
from
+26 −2
Draft

test(verify): scope static-screen crash expectations by platform #2949

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7275557
test(verify): sync static-screen fragment-span expectations
AasishDairelSahayaGrinspan Oct 22, 2026
658261e
test(verify): keep Linux and Windows crash expectations
AasishDairelSahayaGrinspan Oct 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 26 additions & 2 deletions crates/verify/expectations.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,17 +367,41 @@ link = "https://github.com/CapSoftware/Cap/actions/runs/38745219281"
# ci/fixproof-crash-<a|b1|c|ce> (runs 38850662667, 38850661576, 38850663436,
# 38850662102), which removes exactly its entries. Fixes: #2640 (bug A),
# #2641 (bug B1), #2643 (bug C), #2644 (bug E).
#
# bug B1 has different symptoms per platform. Linux and Windows still lose
# the first static-screen fragment because a 60-frame keyframe interval spans
# 20 s of capture while the recorder dies at 11 s. macOS recovers that
# fragment within the loss-time and missing bounds, but the keyframe-only cut
# still makes the complete fragments span 4 s of capture. Tracked by #2641.

[[xfail]]
case = "crash/recorder-kill/inproc/static-screen"
class = "loss-time"
platforms = ["linux", "windows"]
bound = { count = 1, secs = [2.5, 20.5] }
reason = "NEW (bug B1): fragments are cut only at keyframes and every recording encoder's keyframe interval is a frame count (g = 2 s x nominal fps; libx264 keyint 60 here, VideoToolbox 12), so when the screen delivers 3 frames per second a fragment spans 20 s of capture and a crash after 11 s loses all of it (3 of 3 platforms; macOS runners use libx264). Bound: at most one 20 s fragment of capture"
reason = "NEW (bug B1): fragments are cut only at keyframes and every recording encoder's keyframe interval is a frame count (g = 2 s x nominal fps; libx264 keyint 60 here, VideoToolbox 12), so when the screen delivers 3 frames per second a fragment spans 20 s of capture and a crash after 11 s loses all of it (Linux and Windows still use the frame-count interval; macOS recovers within this bound). Bound: at most one 20 s fragment of capture"
link = "https://github.com/CapSoftware/Cap/pull/2641"

[[xfail]]
case = "crash/recorder-kill/inproc/static-screen"
class = "missing"
platforms = ["linux", "windows"]
bound = { count = 1 }
reason = "NEW (bug B1, see loss-time): no fragment of the static recording is complete when the recorder dies, so recovery has nothing (no frames)"
reason = "NEW (bug B1, see loss-time): no fragment of the static recording is complete when the recorder dies, so recovery has nothing (no frames) on Linux and Windows"
link = "https://github.com/CapSoftware/Cap/pull/2641"

[[xfail]]
case = "crash/recorder-kill/inproc/static-screen"
class = "fragment-span"
platforms = ["macos"]
bound = { count = 2 }
reason = "NEW (bug B1): fragments are cut only at keyframes and every recording encoder's keyframe interval is a frame count, so the two complete fragments span 4 s of capture instead of GOP_SECS plus the 0.33 s before the closing frame; macOS reports one fragment-span problem per fragment. The loss-time and missing symptoms no longer occur on macOS"
link = "https://github.com/CapSoftware/Cap/pull/2641"

[[xfail]]
case = "crash/recorder-kill/oop/static-screen"
class = "fragment-span"
platforms = ["macos"]
bound = { count = 3 }
reason = "NEW (bug B1): the out-of-process static-screen recording keeps three complete fragments and each spans 3 to 4 s of capture instead of GOP_SECS plus the 0.33 s before the closing frame; macOS reports one fragment-span problem per fragment. The loss-time and missing symptoms no longer occur on macOS"
link = "https://github.com/CapSoftware/Cap/pull/2641"