Repository navigation
test(verify): scope static-screen crash expectations by platform - #2949
Draft
AasishDairelSahayaGrinspan wants to merge 2 commits into
Draft
AasishDairelSahayaGrinspan wants to merge 2 commits into
AasishDairelSahayaGrinspan wants to merge 2 commits into
Conversation
The known bug B1 static-screen recording now recovers within the loss-time and missing bounds, but macOS still reports fragment-span for the keyframe-only cuts. Replace the stale entries with the measured inproc and oop fragment-span expectations; both cases pass as xfail locally.
Greptile P1: dropping the all-platform loss-time and missing entries removed coverage for Linux and Windows, where the static-screen case still loses the first fragment. Restore those entries scoped to linux and windows, and keep the macOS fragment-span expectations.
Contributor
|
@AasishDairelSahayaGrinspan is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The static-screen crash cases now fail with different classes per platform:
fragment-spanonly; the loss-time and missing checks are within their bounds.loss-timeandmissingsymptoms remain.This updates
crates/verify/expectations.tomlto scope each known failure to the platform where it occurs.Split out of #2776 at the maintainer's request.
Draft
Draft because #2785 is fixing the root cause of these crash failures. Do not merge this while #2785 is in flight; if #2785 lands first, these entries may need to be dropped instead.
Verification
cargo test -p cap-verify-expectcrash/recorder-kill/inproc/static-screenandcrash/recorder-kill/oop/static-screenpass as expected failures (0 FAILED,2 expected failures).