Skip to content

fix: save view defaults without disabling Syslog - #460

Merged
TheWitness merged 1 commit into
developfrom
fix/syslog-view-defaults-preview
Nov 17, 2026
Merged

TheWitness merged 1 commit into
developfrom
fix/syslog-view-defaults-preview

Conversation

@somethingwithproof

@somethingwithproof somethingwithproof commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

Description

Save view defaults after initializing and validating the active tab, preventing the TypeError that makes Cacti disable Syslog and stops subsequent processing. Explain in SQL Expression previews that processed messages are outside their incoming-only scope. No rule matching or notification behavior changes.

Related Issue

Fixes #458. Ref #459: the misleading preview is clarified; the reported processing failure remains unverified, so #459 stays open pending confirmation and processor logs.

How Has This Been Tested?

  • Docker, PHP 8.2.35 / MariaDB 11.8: reproduced Latest Build on develop, syslog 5.0: syslog_request_validation error during save view default #458 and verified the SQL matching/processing path; 22 preview tests passed (90 assertions).
  • PHP 8.5.12 / local MariaDB 13.0.2: save-button and session-tab fallback browser regression passed; database confirmed Main Records defaults persisted and Syslog remained enabled. Live pipeline: 39 checks passed.
  • PHP 8.5.12 suite: 667 passed (2776 assertions), with one existing /proc compatibility warning on macOS. PHP/JavaScript/shell syntax, manifest and translation-template checks passed.
  • GitHub CI passed on PHP 8.2, 8.3, 8.4 and 8.5. The experimental PHP 8.6 job failed before tests because the package mirror returned HTTP 503; the failed job has been retried.
  • Preview notice checked in modern/dark themes at 1440 and 640 pixels. Docker became unresponsive during broader checks, so browser and live pipeline checks used a separate disposable local database.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation repository accordingly.

Initialize the active tab before dispatching saved view defaults. Explain incoming-only SQL rule previews so an empty queue is not mistaken for failed alert processing. Add browser regression coverage and focused preview assertions.

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
@sonarqubecloud

Copy link
Copy Markdown

@TheWitness
TheWitness merged commit 69ecae3 into develop Nov 17, 2026
15 of 17 checks passed
@TheWitness
TheWitness deleted the fix/syslog-view-defaults-preview branch November 17, 2026 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Latest Build on develop, syslog 5.0: syslog_request_validation error during save view default

2 participants