Repository navigation
fix: save view defaults without disabling Syslog - #460
Merged
Merged
Conversation
Initialize the active tab before dispatching saved view defaults. Explain incoming-only SQL rule previews so an empty queue is not mistaken for failed alert processing. Add browser regression coverage and focused preview assertions. Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
|
This was referenced Nov 17, 2026
Closed
TheWitness
approved these changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Save view defaults after initializing and validating the active tab, preventing the TypeError that makes Cacti disable Syslog and stops subsequent processing. Explain in SQL Expression previews that processed messages are outside their incoming-only scope. No rule matching or notification behavior changes.
Related Issue
Fixes #458. Ref #459: the misleading preview is clarified; the reported processing failure remains unverified, so #459 stays open pending confirmation and processor logs.
How Has This Been Tested?
/proccompatibility warning on macOS. PHP/JavaScript/shell syntax, manifest and translation-template checks passed.Types of changes
Checklist