You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Latest Build on develop, syslog 5.0: syslog_request_validation error during save view default #458
I was just playing with the new interface, and in the System Log tab, when I try to 'save view default', after selecting View Option, Record type: Main record, and then Save view default.
I got this error:
17/11/2026 06:57:15 - CMDPHP ERRORS DETECTED - DISABLING PLUGIN 'syslog'
--
17/11/2026 06:57:15 - CMDPHP PHP ERROR Backtrace: (CactiShutdownHandler())
17/11/2026 06:57:15 - ERROR PHP ERROR in Plugin 'syslog': Uncaught TypeError: syslog_request_validation(): Argument #1 ($current_tab) must be of type string, null given, called in /usr/share/cacti/plugins/syslog/syslog.php on line 2853 and defined in /usr/share/cacti/plugins/syslog/syslog.php:1350 Stack trace: #0 /usr/share/cacti/plugins/syslog/syslog.php(2853): syslog_request_validation() #1 /usr/share/cacti/plugins/syslog/syslog.php(73): save_settings() #2 {main} thrown in file: /usr/share/cacti/plugins/syslog/syslog.php on line: 1350
```
Reproduced on Syslog develop 6c8238f in Docker with PHP 8.2.35, MariaDB 11.8 and Cacti 1.2.x (bc5a1a1). An authenticated save request with action=save, tab=syslog and removal=-1 produces the same trace, and Cacti disables the plugin:
syslog_request_validation(): Argument #1 ($current_tab) must be of type string, null given
#0 syslog.php(2853): syslog_request_validation(NULL, true)
#1 syslog.php(73): save_settings()
CMDPHP ERRORS DETECTED - DISABLING PLUGIN 'syslog'
The save action exits at lines 72–75, before the tab validation/session restoration and $current_tab assignment at lines 137–158. save_settings() therefore receives an uninitialized global even though the browser sends tab=syslog. The tab needs to be initialized and validated before that handler runs, using the same allowlist and session fallback as the normal viewer request.
Until this is fixed, avoid “Save view defaults” and re-enable Syslog in Plugin Management if this error disabled it. This can also stop the alert processing reported in #459; changing Record Type itself is not the cause.
Fix proposed in #460. The save action now runs after active-tab initialization, and the browser regression confirms that Main Records defaults persist and Syslog stays enabled. The same test covers requests that restore the tab from the session.
Activity
somethingwithproof commentedon Nov 17, 2026
Reproduced on Syslog develop
6c8238fin Docker with PHP 8.2.35, MariaDB 11.8 and Cacti 1.2.x (bc5a1a1). An authenticated save request withaction=save,tab=syslogandremoval=-1produces the same trace, and Cacti disables the plugin:The save action exits at lines 72–75, before the tab validation/session restoration and
$current_tabassignment at lines 137–158.save_settings()therefore receives an uninitialized global even though the browser sendstab=syslog. The tab needs to be initialized and validated before that handler runs, using the same allowlist and session fallback as the normal viewer request.Until this is fixed, avoid “Save view defaults” and re-enable Syslog in Plugin Management if this error disabled it. This can also stop the alert processing reported in #459; changing Record Type itself is not the cause.
somethingwithproof commentedon Nov 17, 2026
Fix proposed in #460. The save action now runs after active-tab initialization, and the browser regression confirms that Main Records defaults persist and Syslog stays enabled. The same test covers requests that restore the tab from the session.
arno-st commentedon Nov 17, 2026
Ok, I can confirm it works flawlessly
TheWitness commentedon Nov 17, 2026
Cool. More small changes likely before release. Thanks for the feedback.