Repository navigation
Conversation
…ies on CIRISEdge clears its per-link attribution at LinkClosed (CIRISEdge#810). It therefore relies on this: a receiver-side resource whose link closes while its off-lock assembly (#71) is running fails exactly once, with ResourceFailed{LinkClosed}, and that failure is emitted before LinkClosed. The assembly's late result then yields no ResourceCompleted and no second failure. The #71 test only checked that some failure appeared and that the late result delivered nothing. It now asserts the full invariant. A variant covers a close sent by the peer. Mutation-checked: when remove_link stops taking the assembling resource, both variants fail. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BXj7C4ZeFuczxxDVadAHZ5
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
emooreatx
added a commit
that referenced
this pull request
Oct 8, 2026
… telemetry (#77), the close-during-assembly pin Lands PRs #74, #75 and #76. - #74: direct-link upgrade, wire-compatible with rns-rs. Five Codex rounds. - #75: a test pinning the close-during-assembly invariant CIRISEdge relies on. - #76: link census, link list, lifecycle counters, the mirror-divergence alarm and the metrics facade. Four Codex rounds. The final fixes on #74 (round 5) and #76 (reject_link) answer Codex's own findings. Codex then hit its usage limit and could not review them; each has a test. Releasing on green CI was the maintainer's call. Integration: #74 and #76 overlapped only where both appended to the same places (NodeCore fields, ReticulumNode fields, lib.rs re-exports, the event loop's prologue and timer branch, the lock census). Each commit builds on its own. The apply_inbound citation in event_log.rs follows the combined driver. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019ye3GBY8MB38EsYH5eaZKq
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test-only. Requested from the CIRISEdge side, where it came out of a Codex finding on the v0.29 adoption (CIRISEdge#810).
CIRISEdge clears its per-link attribution at
LinkClosed. It relies on this: a receiver-side resource whose link closes while its off-lock assembly (#71) is running fails exactly once, asResourceFailed{LinkClosed}, emitted beforeLinkClosed. The assembly's late result (complete_resource_assembly) then yields noResourceCompletedand no second failure.The #71 test checked only part of that. It is now one helper that asserts the whole invariant, used for:
close_linkduring assembly;Mutation-checked: if
remove_linkstops taking the resource out ofassembling_resources, both variants fail.🤖 Generated with Claude Code
https://claude.ai/code/session_01BXj7C4ZeFuczxxDVadAHZ5