Repository navigation
Conversation
This was referenced Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add opt-in rainbow, breathing and rumble-linked lighting with an optional idle fade. Effects respect the existing Light page's brightness, low-battery indication, Light Off and native-mode output opt-in. Hardware changes are paced to 40 Hz.
The controller drawing and touch-feedback color follow the actual LED output. Static color remains the default. This final layer completes the seven-tool Lab and its documentation without changing the previously accepted installed behavior.
Dependencies and focused review
Stacked PR 7/7; depends on #15 and the earlier layers, starting with #9. All targets are upstream
main, so GitHub's Files changed view currently includes unmerged dependencies. Review only this feature's incremental diff (commitb8c18c9).Merge in the order below. Preserve the shared commit ancestry when merging, or rebase the remaining branches after squash/rebase merges so already-merged layers disappear from their diffs.
Validation
cargo fmt --all --checkcargo clippy --workspace --all-targets --release --locked -- -D warningscargo test --workspace --locked: 275 passed, 5 driver/manual tests ignored, zero failures (Windows x64).All new tools are disabled by default. No additional dependencies are added. Cross-platform CI results are reported by GitHub checks.