Repository navigation
Add the dive number and logfile name to DroneInfo - #323
Merged
Merged
Conversation
Lets recordings that store DroneInfoTel (e.g. .mbez multibeam files) be tied back to the dive logfile they were recorded in. log_name stays unique when the dive counter restarts, e.g. after the storage is replaced. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
follesoe
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds two fields to
DroneInfoso a recording that storesDroneInfoTelcan be tied back to the dive it was recorded in:uint32 dive_number = 15: the counter at the end of the dive logfile name (LOG_NUMBERin be-ros-start), e.g.231forBYEDP070012_ea9ac92e040aa9d4_00231.bez.0means unknown.string log_name = 16: the logfile name without extension, e.g.BYEDP070012_ea9ac92e040aa9d4_00231. The counter restarts after an SSD swap or a reformat, which is why the log name has a storage id in it (BluEye-Robotics/p2_drone#988).log_namestays unique when that happens.The first user is the multibeam
.mbez: once a recording has left the drone, nothing in it says which dive it belongs to. Both fields are additive, so existing clients ignore them.Testing
./protolint.shis clean.protoc --cpp_outon all proto files.cross-jetson-update), installed into the SDK sysroot on top of the mission branch build it currently holds. p2_drone builds against it.Related
dive_numberandlog_nameinDroneInfoDroneInfoTelinto.mbezrecordingsMerge order: this PR first, then p2_drone (its CI builds against ProtocolDefinitions master).
🤖 Generated with Claude Code