Skip to content

Anw 2838 keyboard dropdown #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
davezuckerman wants to merge 2 commits into from
+26 −2
Closed

Anw 2838 keyboard dropdown #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00ee6c4
keyboard accessibility for collection management dropdown accordian
davezuckerman Sep 16, 2026
f29a0ea
Using button instead of <a> for accordion dropdown
davezuckerman Sep 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions frontend/app/views/collection_management/_show.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,15 @@
<div class="details my-3" id="<%= section_id %>_accordion">
<div class="card">
<div class="card-header panel-heading">
<div class="row collapsed accordion-toggle" data-toggle="collapse" data-parent="#<%= section_id %>_accordion" data-target="#<%= section_id %>_collection_management" aria-expanded="false" aria-controls="<%= section_id %>_collection_management">
<button type="button" class="row collapsed accordion-toggle" data-toggle="collapse" data-parent="#<%= section_id %>_accordion" data-target="#<%= section_id %>_collection_management" aria-expanded="false" aria-controls="<%= section_id %>_collection_management">
<div class="col-md-1">
<span class="glyphicon"></span>
</div>
<div class="col-md-4">
<%= t("collection_management.processing_priority") %>:
<strong><%= t("enumerations.collection_management_processing_priority.#{collection_management['processing_priority'] || 'none'}", :default => collection_management['processing_priority']) %></strong>
</div>
</div>
</button>
</div>
<div id="<%= section_id %>_collection_management" class="collapse">
<%= read_only_view(collection_management) %>
Expand Down
24 changes: 24 additions & 0 deletions frontend/spec/features/collection_management_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,30 @@
expect(page).to have_text 'No records found'
end

it 'provides a keyboard-operable accordion control on the accession show page' do
accession = create(
:accession,
collection_management: {
"processing_priority" => "high"
}
)

begin
visit "/accessions/#{accession.id}"

within '#accession_collection_management_' do
toggle = find('.accordion-toggle')
expect(toggle.tag_name).to eq('button')
expect(toggle[:type]).to eq('button')
expect(toggle[:'data-target']).to eq('#accession_collection_management__collection_management')
expect(toggle[:'aria-controls']).to eq('accession_collection_management__collection_management')
end
ensure
accession.delete
run_index_round
end
end

it 'is browseable even when its linked accession has no title' do
now = Time.now.to_i

Expand Down