Skip to content

Anw 2838 keyboard dropdown - #8

Closed
davezuckerman wants to merge 2 commits into
ANW-2833from
ANW-2838-keyboard-dropdown
Closed

davezuckerman wants to merge 2 commits into
ANW-2833from
ANW-2838-keyboard-dropdown

Conversation

@davezuckerman

Copy link
Copy Markdown

Using button for collection management accordion dropdown.

Related Ticket (JIRA or GitHub Issue)

[ANW-2838]

Summary

Collection management was inaccessible via keyboard access. Using always for keyboard control and will not confuse screen readers.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change, for example API endpoint renaming)
  • My change requires a change to the documentation - If so elaborate:

Checklist:

  • I have read and agree to the CONTRIBUTING document.
  • I have authority to submit this code. - See our licensing
  • Have you added tests to cover these changes? If not why:

@awilfox awilfox left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem with this change is that button doesn't support having the row class, so the columns inside look weird and stack wrong.

I can push the minimal diff I have, which I've only applied to dates so far, if you'd like a template to work with.

@davezuckerman

Copy link
Copy Markdown
Author

@awilfox This merge request is unnecessary now since it was dealt with in your other accordion fixes correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants