Anw 2838 keyboard dropdown - #8
Closed
davezuckerman wants to merge 2 commits into
Closed
davezuckerman wants to merge 2 commits into
davezuckerman wants to merge 2 commits into
Conversation
anarchivist
approved these changes
Sep 21, 2026
awilfox
requested changes
Sep 21, 2026
awilfox
left a comment
Member
There was a problem hiding this comment.
The problem with this change is that button doesn't support having the row class, so the columns inside look weird and stack wrong.
I can push the minimal diff I have, which I've only applied to dates so far, if you'd like a template to work with.
Author
|
@awilfox This merge request is unnecessary now since it was dealt with in your other accordion fixes correct? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using button for collection management accordion dropdown.
Related Ticket (JIRA or GitHub Issue)
[ANW-2838]
Summary
Collection management was inaccessible via keyboard access. Using always for keyboard control and will not confuse screen readers.
Screenshots (if appropriate):
Types of changes
Checklist: