Skip to content

Introduce owner-task scheduling and its regression harness - #78

Open
BenCodez wants to merge 2 commits into
masterfrom
vp-work/mcperks-owner-tasks-p1
Open

BenCodez wants to merge 2 commits into
masterfrom
vp-work/mcperks-owner-tasks-p1

Conversation

@BenCodez

@BenCodez BenCodez commented Oct 26, 2026 •

Copy link
Copy Markdown
Owner

Introduce owner-task scheduling for later perk changes. Immediate and delayed admissions complete through either the action or the retirement callback. A disable observer retires pending admissions even when the platform drops queued callbacks. Spigot and Paper use synchronous native delays in ticks.

Existing perk callers do not use this helper yet. Integrators must initialize it before the first admission in onPostLoad and shut it down at the start of onUnLoad. Work submitted outside an active lifecycle retires immediately. Retirement callbacks run outside the ownership lock and must not depend on another plugin-owned callback.

Recorded local packages passed all 40 scheduler tests with the candidate dependency set and with published AdvancedCore 3.8.1 and SimpleAPI 1.0.1. Coverage includes native scheduling adapters, disable, rejection and late callbacks at controlled boundaries. Hosted Maven, native gameplay and old-binary compatibility remain unverified. The integrated feature set remains in #76.

Created with assistance from OpenAI Codex.

Retire cancelled admissions and isolate lifecycle epochs. Preserve the original scheduler regressions and add native-cancellation coverage.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T03:08:51.668970Z 697b3fa Manual request
🔒 Security Review ✅ Completed 2026-10-26T02:42:39.191453Z 8b34e81 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9b1f5013-7dbe-40b6-9f97-1cf33809289b
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Owner Author

@codex security review

Please perform a fresh focused security review of the actual current PR head 697b3fa6fa734761749e3a0b9d2d7e0d2ba2f9ba. Review the complete standalone owner-task scheduling change and its affected callers/dependency contract, focusing on lifecycle admission/retirement, stale callbacks, disable/re-enable races, callback failures, thread ownership and build/package trust boundaries. Include the two test additions since the earlier security-reviewed head. Report actionable findings against this exact head; the earlier security result is not being treated as current-head coverage. This requests review only, with no source changes, server execution or merge action.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: 697b3fa6fa

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant