Skip to content

Add opt-in automation effects, usage charges and durable perk management - #76

Draft
BenCodez wants to merge 23 commits into
masterfrom
codex/selected-effects-and-lifecycle
Draft

BenCodez wants to merge 23 commits into
masterfrom
codex/selected-effects-and-lifecycle

Conversation

@BenCodez

@BenCodez BenCodez commented Oct 10, 2026 •

Copy link
Copy Markdown
Owner

Add opt-in AutoBlockRefill, bounded VeinMining, RightClickHarvest and PrecisionMode. The combined draft also adds personal usage charges, queue management, banked personal time, diagnostics and local statistics. Existing perks keep their defaults when the optional settings are absent. The smaller review slices are #78, #80, #86, #87 and #88.

  • Personal charges reserve durably before effects. Proved-unused units are released; uncertain effects remain spent. Charged shared perks are unsupported.
  • Queue entries reserve entitlement while waiting and consume it once on start. Administrators can pause and reorder the queue. An uncertain start is held for recovery.
  • Banked time counts only eligible online time; existing absolute expiry is preserved. Effects that cannot safely pause are ineligible for banking.
  • Diagnostics use the execution rules without debiting balances. Statistics are local and bounded, with advisory counters reset on restart.

The combined feature depends on AdvancedCore #360 for shutdown and final-file publication APIs. Normal dependency delivery and compatibility with the prior scheduler binary API remain open. A separate local banked-time follow-up reported 115 focused tests and 455 clean-package tests with candidate dependencies; those results do not validate this published head. Hosted Maven and live gameplay, protection integrations, databases and restart acceptance remain unverified. MCPerks does not declare Folia support.

Retained historical follow-up records

These preserved reports describe their stated follow-up revisions and candidate inputs. They are not new current-head validation results.

Registered banked-time commands now have 28 new regression cases covering permissions, self/staff/console identity, pure reads, supported limits, invalid input, durable writes before scheduled replies, uncertain publication failures and restart recovery. Tests exercise the real registered handlers, bank controller pause path and storage; the native online-refresh handoff is isolated.

Validation: 115 focused tests and all 455 clean-package tests pass, retaining every previous case. Exact compatible AdvancedCore candidate and published SimpleAPI dependency bytes were verified. Production code, existing tests and tracked dependency selectors are unchanged; shaded runtime contents match the previous candidate. Fresh independent focused review and current-source publication checks are recorded with this update. Live eligibility/player scheduling, normal dependency delivery and final feature acceptance remain outstanding. Keep this PR in draft.

Registered Diagnose command coverage now exercises self/other permissions, online target selection, console handling, deferred target reads, requester reply scheduling, disconnects and read-only durable state. Ten new cases use the production handlers and renderer with real feature/charge stores; existing tests and production behavior are unchanged.

Validation: 28 focused tests and 427 clean-package tests pass with the compatible AdvancedCore candidate and published SimpleAPI snapshot. All 417 prior cases remain, and the shaded artifact's entry bodies equal the previous candidate. These tests use controlled platform dispatch; final normal-dependency and live-platform acceptance remain outstanding. Keep this PR in draft.

Harvest admission regressions

Test-only follow-up 5934bf383d31a28a852af6c24e2a29ad4e1989fa adds 15 cases across all five supported crops. Mature crops without a replant seed and immature crops leave inventory, blocks and the durable labeled ledger unchanged without scheduling gameplay. Eligible controls reserve before breaking and consume one seed and one successful harvest use, including duplicate callback handling. Production code, existing tests and the tracked dependency POM are unchanged.

Focused RightClickHarvestAdmissionTest: 15 passed. Full clean package: 399 passed, zero failures/errors/skips, including every prior 384 case, in 39 seconds. Validation used an isolated temporary selector for AdvancedCore PR360 source 5da4c2b74c06d2d3b5c0fb32bff9ca3e71d8f71f, SDK SHA256 4edcce11ba62e34294096ac93dc3d7fa7e261f84abe4952259c056aa0e44ef42, and published SimpleAPI43 9b6d924658a236ae0ac0f1aadc8c5f9fb6a7306253c306c7496723836cb6adeb; all 26 actual suite classpaths were checked. Packaged JAR SHA256 c28af61db0ef3e5b293e774d508822965774b4bbff3fc0282fcbd772533fb94d, 9,302,085 bytes. Every ZIP entry matches the prior exact-dependency candidate; archive metadata changes the outer SHA. Tests/JUnit/Mockito remain excluded. Fresh independent focused new-test and affected-caller review: No findings.

These are listener/real-ledger tests with mocked Bukkit world/player boundaries, not native protection-plugin or live-world acceptance. The PR stays draft; remaining complete feature, normal dependency and runtime acceptance gates are unchanged. MCPerks does not declare Folia support.

@coderabbitai

coderabbitai Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: de369e53-c3f7-425b-ac14-3d38dd0e2911
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-10T18:35:38.582318Z 37c912b New commits
🔒 Security Review ✅ Completed 2026-10-10T00:20:22.298573Z c2d0d2b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c2d0d2b3c8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 07d44dc9df

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c58888c0d9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b769075a14

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cf1ebc8702

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 13e4d21e8f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6d097a02dd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 37c912baa6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@BenCodez
BenCodez marked this pull request as draft October 10, 2026 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant