Repository navigation
Add guarded Android coding and PR dynamic workflow, Fixes AB#3805593 - #482
Merged
Shahzaib (shahzaibj) merged 79 commits intoNov 2, 2026
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…iew skills Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…n code-feature Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…redits cap Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…imits Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…tree Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…ications Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…tance criteria Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…n prompt mode Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…seudo-conflicts Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…e unavailable Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…cation Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…ktrees Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…skill Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…nd worktree snapshot guards Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…-observer workflow Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…tus blocks, and observer anti-loop Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…d GHE PR rules from E2E log Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…rge/changelog rules from past sessions Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
… in SKILL.md Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
… roles Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
… code-feature Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
… repo inference Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…ile androidTest only) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…xtract PR ID safely Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…air runs Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…nd ADO check build logs Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…d fix rolloutTag regex Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…on origin Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…y in top-level sessions Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…after review passes Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…sh-repair Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…erver.mjs Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…ardown statuses are ignored Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…feat-coding-workflow
…e same PBI Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
… outer agent passes createPullRequests:false Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…mmit on clean checkout Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
… cannot revert HEAD Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…y permission fallback Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Shahzaib (shahzaibj)
changed the title
…sts/slugs, checkout remotes, and matched thread resolution Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Cesar Acosta (cacosta33)
approved these changes
Nov 2, 2026
Shahzaib (shahzaibj)
added a commit
that referenced
this pull request
Nov 4, 2026
…-test deferral in code-feature, Fixes AB#3805593 (#485) ## Summary Fixes the four issues encountered when running `code-feature` on Windows after PR #482: 1. **Windows `.bat` / `gradlew` execution in `runLocalVerificationGate` (`EINVAL` / `ENOENT`):** - Added `runWindowsBatchFileSafely` (invoking `cmd.exe /d /s /v:off /c` with `windowsVerbatimArguments: true` and strict argument validation) and normalized `./gradlew` / `.\gradlew` to `gradlew.bat` on Windows inside `defaultExec`. - Automatically appends `--no-daemon` and `--max-workers=2` and enforces a bounded 25-minute timeout (`DEFAULT_GRADLE_VERIFICATION_TIMEOUT_MS`) + `Android Studio\jbr` JDK fallback. 2. **Defer `connected*AndroidTest` / device tasks to CI:** - Updated `parseAllowedGradleVerificationCommand` and `runLocalVerificationGate` so `connected*AndroidTest`, `connectedCheck`, `deviceCheck`, and `managedDevice*` tasks (including `-Pandroid.testInstrumentationRunnerArguments...`) are recorded in `deferredNotes` for CI execution instead of failing local verification. 3. **Natural-prompt PBI ID extraction priority over PR link references:** - Added `stripPullRequestReferenceText` and updated `extractWorkItemIdsFromText` / `normalizeTask` so prompts like `"implement the PBI 3804404 using ... [Add guarded Android coding and PR dynamic workflow, Fixes AB#3805593](https://github.com/.../pull/482)"` bind and auto-fetch `3804404` instead of matching `[AB#3805593](https://identitydivision.visualstudio.com/fac9d424-53d2-45c0-91b5-ef6ba7a6bf26/_workitems/edit/3805593)` inside the referenced PR title. 4. **Auto-clone missing target repo + `core.longpaths=true` on Windows:** - Updated `ensureIsolatedTargetWorktree` to set `core.longpaths=true` and auto-clone missing target sub-repositories in real `android-complete` workspaces. Fixes [AB#3805593](https://identitydivision.visualstudio.com/fac9d424-53d2-45c0-91b5-ef6ba7a6bf26/_workitems/edit/3805593) ## Test Plan - `node --test .github/extensions/CodeFeature/workflow.test.mjs .github/extensions/DevDesignDoc/workflow.test.mjs` (53/53 passing, including real Windows `.bat` fixture execution in a path with spaces, unsafe-argument rejection, `connected*AndroidTest -P...` deferral, and PBI prompt extraction with embedded PR links) - `git diff --check origin/master...HEAD` --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a standalone, repository-scoped Copilot Dynamic Workflow (
code-feature) under.github/extensions/CodeFeature/for Android coding and pull request creation, modeled after.github/extensions/DevDesignDoc(design-feature).Fixes AB#3805593
Related to AB#3800277 and parent feature AB#3797944.
Approach
.github/extensions/CodeFeature/extension.mjswith workflow namecode-featureand role-scoped custom agents (code-evidence,code-builder, and read-onlycode-reviewer).AB#<id>work-item linkage; gather repository evidence with revisions and facts before coding.code-builderto produce the implementation, unit tests, requirement-to-file/test traceability, and PR metadata.code-revieweracross up to 3 fix iterations max (fix-1..3): run deterministic structural/diff/workspace checks and an independent 9-point rubric review on each round, returning structured findings tocode-builderuntil zero findings remain (or halting withNO-GOand restoring modified workspace files if 3 fix iterations are exhausted).Fixes AB#<id>, requirements traceability table, unit test plan, compatibility and rollout notes) only after all deterministic checks and independent review criteria pass.Checks
node --check .github/extensions/CodeFeature/extension.mjsandnode --check .github/extensions/CodeFeature/workflow.mjspassed..github/extensions/CodeFeature/workflow.test.mjspassed (plus all 15DevDesignDoctests).project:CodeFeaturestatusrunning) and zero-agent validation in the Copilot SDK runtime.