Repository navigation
Fix Windows Gradle batch runner, PBI prompt extraction, and connected-test deferral in code-feature, Fixes AB#3805593 - #485
Merged
Shahzaib (shahzaibj) merged 15 commits intoNov 4, 2026
Conversation
…-test deferral in code-feature, Fixes AB#3805593 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
✅ Work item link check complete. Description contains link AB#3805593 to an Azure Boards work item. |
… post-builder Gradle runs Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
… worktree Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…bserver repair Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…ad status PATCH Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…l timezone offset Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…ment ADO build is running Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…S/502/503 task failures Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…cy requeue Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
moumighosh
approved these changes
Nov 3, 2026
…eption is parsed as string Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
… infra failures Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…and guard unrelated base-branch test failures Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…r commit Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the four issues encountered when running
code-featureon Windows after PR #482:.bat/gradlewexecution inrunLocalVerificationGate(EINVAL/ENOENT):runWindowsBatchFileSafely(invokingcmd.exe /d /s /v:off /cwithwindowsVerbatimArguments: trueand strict argument validation) and normalized./gradlew/.\gradlewtogradlew.baton Windows insidedefaultExec.--no-daemonand--max-workers=2and enforces a bounded 25-minute timeout (DEFAULT_GRADLE_VERIFICATION_TIMEOUT_MS) +Android Studio\jbrJDK fallback.connected*AndroidTest/ device tasks to CI:parseAllowedGradleVerificationCommandandrunLocalVerificationGatesoconnected*AndroidTest,connectedCheck,deviceCheck, andmanagedDevice*tasks (including-Pandroid.testInstrumentationRunnerArguments...) are recorded indeferredNotesfor CI execution instead of failing local verification.stripPullRequestReferenceTextand updatedextractWorkItemIdsFromText/normalizeTaskso prompts like"implement the PBI 3804404 using ... [Add guarded Android coding and PR dynamic workflow, Fixes AB#3805593](https://github.com/.../pull/482)"bind and auto-fetch3804404instead of matching[AB#3805593](https://identitydivision.visualstudio.com/fac9d424-53d2-45c0-91b5-ef6ba7a6bf26/_workitems/edit/3805593)inside the referenced PR title.core.longpaths=trueon Windows:ensureIsolatedTargetWorktreeto setcore.longpaths=trueand auto-clone missing target sub-repositories in realandroid-completeworkspaces.Fixes AB#3805593
Test Plan
node --test .github/extensions/CodeFeature/workflow.test.mjs .github/extensions/DevDesignDoc/workflow.test.mjs(53/53 passing, including real Windows.batfixture execution in a path with spaces, unsafe-argument rejection,connected*AndroidTest -P...deferral, and PBI prompt extraction with embedded PR links)git diff --check origin/master...HEAD