Accept --wp auto-update as the CLI name for the auto-update mode - #4750
Open
gcsecsey wants to merge 1 commit into
Open
Accept --wp auto-update as the CLI name for the auto-update mode#4750gcsecsey wants to merge 1 commit into
gcsecsey wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The agent-facing skill update lacks required eval coverage, and its validation message omits the supported latest alias.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 2
- Review effort level: Balanced
Comment on lines
+45
to
+47
| __( | ||
| 'Must be: "%s", "nightly", or a valid version number (e.g., "6.4", "6.4.1", "6.4-beta1")' | ||
| ), |
| ``` | ||
|
|
||
| **Options:** `--name`, `--wp` (default: "latest", min: 6.2.1), `--php` (default: 8.4, choices: 8.5/8.4/8.3/8.2/8.1/8.0/7.4), `--domain`, `--https`, `--blueprint` (local JSON file path), `--admin-username` (default: "admin"), `--admin-password` (auto-generated if omitted), `--admin-email` (default: "admin@localhost.com"), `--start` (default: true, use `--no-start` to skip), `--skip-browser`, `--skip-log-details`. | ||
| **Options:** `--name`, `--wp` (default: "auto-update", which keeps WordPress core auto-updating; "latest" is accepted as an alias; pin with a version number, min: 6.2.1), `--php` (default: 8.4, choices: 8.5/8.4/8.3/8.2/8.1/8.0/7.4), `--domain`, `--https`, `--blueprint` (local JSON file path), `--admin-username` (default: "admin"), `--admin-password` (auto-generated if omitted), `--admin-email` (default: "admin@localhost.com"), `--start` (default: true, use `--no-start` to skip), `--skip-browser`, `--skip-log-details`. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
I used Opus 5 for implementation and tests.
Proposed Changes
#4702 renames the "latest" WordPress version option to "Auto-update" in both UIs. This PR updates the naming in the CLI to keep it consistent.
--wp auto-updatenow selects that mode, matching what the apps show.--wp latestkeeps working as an alias too, so existing scripts and blueprints are unaffected.latestis still the internal value, and it still names a cache directory, a segment of the wordpress.org download URL, and the persisted site setting. The alias is resolved where the CLI parses input and never reaches storage.Two side effects:
blueprint use --wpwas not validated at all. It needed the alias mapping anyway, and the shared coercion brings validation with it, so a bad value now fails at parse time instead of throwing from inside the download helper.site createsaidlatest (7.1); it now saysAuto-update (7.1), matching the apps.Testing Instructions
npm run cli:buildThe new value works
~/.studio/cli.json: the site should have"isWpAutoUpdating": true.lateststill works--wp 6.9--wp latestisWpAutoUpdatingshould gofalse, then back totrue. The site has to be runningfor
config set --wpto apply, sostudio startit first.Help text
site create --help,config set --helpandblueprint use --helpshould alldescribe
auto-updateand mention thatlatestis accepted.Pre-merge Checklist