Split the WordPress version setting into an update mode and a version picker - #4752
Draft
gcsecsey wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
For implementation and tests: lifting the control from #4747, fixing the two edge cases below, and updating the affected tests.
Proposed Changes
The WordPress version setting mixes two decisions: whether the site updates itself, and which version it is pinned to. #4702 fixes the wording of the single dropdown, but the two decisions still share one control. This splits them into
Automatic updatesandSelect a version, so the picker only means "pin this version". The interaction and copy come from Shaun's exploration in #4747; this PR takes only that control, not the wider settings redesign in that PR.Unknown versionin the picker. Before, the picker had no option for that state and silently displayed the newest offer instead.Select a versionwould open an empty picker.Automatic updateswhile that mode is selected, which is the rule Set the right expectation for the "latest" WordPress version setting #4702 uses for its bracketed label.Testing Instructions
npm run cli:build:ui && node apps/cli/dist/cli/main.mjs ui --no-open, then open a site and its Settings tab.Automatic updatesselected, and its description names the version the site runs now.Select a version, pick a different version, and confirmSave settingsbecomes enabled.Pre-merge Checklist