[Upd4ting]

Why

The docs say @Get("") registers the controller root, so Controller("/users") with @Get("") should register /users. It registered /users/, which is what getRegisteredRoutes() and every RouteHandler.location consumer saw.

Fixes #75

What changes

ProcessCallback in src/routes.ts no longer appends / when the route location is empty. The full location is the controller location, and an empty controller location still falls back to /. Every other combination keeps the old join, ${controller.location}/${location ?? key} with repeated slashes collapsed.

The issue asked whether to change the code or the docs. This PR changes the code, because the docs state the intended contract and @antelopejs/api serves both forms the same way. Its registerHandler splits the location on / and drops empty parts, so no served route changes. Only the registered location string does.

flowchart LR
  A["@Get(location)"] --> B{"location ?? key is empty?"}
  B -- yes --> C["controller.location, or / when that is empty"]
  B -- no --> D["controller.location + / + segment"]
  C --> E["collapse repeated slashes"]
  D --> E
  E --> F["RegisterRoute"]

Loading

Proof

src/tests/route-decorators.test.ts gains two cases. The first fails on any implementation that keeps the trailing slash for an empty location. The second fails on one that turns Controller("/") with @Get("") into an empty location.

Before the fix (pnpm exec ajs module test . -f dist/tests/route-decorators.test.js on main's src/routes.ts):

  Route decorators
    1) register an empty location at the controller root, without a trailing slash
    ✔ register an empty location under the root controller at /
    ✔ refuse an accessor, which has no method to register
    ✔ refuse a method of a class that Controller did not create
    ✔ refuse a symbol-keyed method without a location, which has no path segment
    ✔ accept a symbol-keyed method given a location


  5 passing (30ms)
  1 failing

  1) Route decorators
       register an empty location at the controller root, without a trailing slash:

      AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
+ actual - expected

  [
+   '/empty-location/'
-   '/empty-location'
  ]

      + expected - actual

       [
      -  "/empty-location/"
      +  "/empty-location"
       ]

      at Context.<anonymous> (dist/tests/route-decorators.test.js:93:31)
      at process.processImmediate (node:internal/timers:574:21)

After the fix:

  Route decorators
    ✔ register an empty location at the controller root, without a trailing slash
    ✔ register an empty location under the root controller at /
    ✔ refuse an accessor, which has no method to register
    ✔ refuse a method of a class that Controller did not create
    ✔ refuse a symbol-keyed method without a location, which has no path segment
    ✔ accept a symbol-keyed method given a location


  6 passing (16ms)

pnpm run checks: Checks: 9 passed, 0 failed. The full suite includes routing.test.ts, which serves a @Post("") route over HTTP.