Repository navigation
docs(verify): retire the fixed #75 and #76 known findings - #104
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The verify-interface skill still listed #75 and #76 as open known findings. Both are closed. #99 registers
@Get("")at the controller root, and #101 refuses@Connectionon handlers that never receive a connection. An agent reading the skill learned behaviour that is no longer true. Theroute-locationsjourney also stripped one trailing slash, so it pinned neither form of the root location.What changed
features/README.md: the Known findings section is removed. Its table held only @Get("") registers the controller location with a trailing slash, but docs say it registers the controller root #75 and @Connection is documented as WebSocket-only but nothing enforces it #76, and its "No journey pins either behaviour" line went with it.features/routes.md: the @Get("") registers the controller location with a trailing slash, but docs say it registers the controller root #75 gotcha is removed. Theroute-locationssub-feature now names the root location it pins.scenarios-second.ts:route-locationscomparesr.handler.locationas registered and drops.replace(/\/$/, ""). The expected line already held/usersfor@Get(""), so it now pins the root form exactly.@Connection: fix(parameters): refuse @Connection on handlers that never receive a connection #101 already covers the refusal in theinjected-valuesjourney (connectionOnGet, listed infeatures/parameter-sources.md). This PR does not change it.Proof
Verify journeys the retired findings pointed at, run on this branch's packed build:
The same
route-locationsjourney withsrc/routes.tsset back to the pre-#99 join (${controller.location}/${segment}), a local change that was not committed:With the strip in place, that regression would pass.
pnpm run checks:flowchart LR A["@Get("") on Controller("/users")"] --> B[ProcessCallback] B --> C["location /users"] C --> D{"route-locations journey"} D -- "before: strip one trailing slash" --> E["/users and /users/ both pass"] D -- "after: compare as registered" --> F["only /users passes"]