Skip to content

chore(studio): remove unused discoveryContext and app.css #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pkmaster21 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore(studio): remove unused discoveryContext and app.css #519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dcca861
chore(studio): remove unused discoveryContext and app.css (#401)
pkmaster21 Oct 31, 2026
ec0ac69
Merge branch 'main' into fix/studio-dead-code
pkmaster21 Nov 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).

## [Unreleased]

### Removed
- **Studio: two leftovers nothing used.** The `discoveryContext` helper in `studio/wifi_discovery.go` was never called (WiFi discovery builds its own context), and `studio/frontend/src/app.css` held Wails starter-template styles that nothing imported. No behavior changes. The third item in the issue, a commented-out `replace` in `studio/go.mod`, was already removed in #477. (#401)

## [0.26.1] - 2026-10-26

### Security
Expand Down
54 changes: 0 additions & 54 deletions studio/frontend/src/app.css
View file
Open in desktop

This file was deleted.

10 changes: 0 additions & 10 deletions studio/wifi_discovery.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import (
"context"
"fmt"
"sync"
"time"

"github.com/grandcat/zeroconf"
wailsruntime "github.com/wailsapp/wails/v2/pkg/runtime"
Expand Down Expand Up @@ -121,12 +120,3 @@ func entryToDevice(e *zeroconf.ServiceEntry) WiFiDevice {
}
return dev
}

// Helper used by App methods to construct a default browse context tied to
// the App's lifecycle.
func discoveryContext(parent context.Context) (context.Context, context.CancelFunc) {
if parent == nil {
parent = context.Background()
}
return context.WithTimeout(parent, 24*time.Hour) // effectively forever; user stops manually
}
Loading