Repository navigation
chore(studio): remove unused discoveryContext and app.css - #519
Open
pkmaster21 wants to merge 2 commits into
Open
pkmaster21 wants to merge 2 commits into
pkmaster21 wants to merge 2 commits into
Conversation
…ystems#401) Signed-off-by: David Z <56000498+pkmaster21@users.noreply.github.com>
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
pbertsch
added a commit
that referenced
this pull request
Oct 31, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
Fixes #401.
Removes the two Studio leftovers from #401 that are still on
main:discoveryContextinstudio/wifi_discovery.go. It came in with mDNS WiFi discovery (feat(studio,agent): mDNS auto-discovery for WiFi physical devices #86) but was never called:wifiDiscovery.Start()builds its own context withcontext.WithCancel. It was the only use of thetimeimport, so that goes too.studio/frontend/src/app.css. It came in with the Studio beta (v0.6.0: connection stability + MCP binary split + Studio (Beta Preview) #77) and holds Wails starter-template styles (#logo,.result,.input-box). Nothing imports it;main.tsonly importsstyle.css.The third item, the commented-out
wails/v2replaceinstudio/go.mod, was already removed in #477, so this PR leavesgo.modalone (the livereplace ... => ..stays). No behavior changes.Evidence
Before (
main) and after (this branch):Checks on this branch:
flutter testnot run: nothing underprobe_agent/changed.AI use
I used Claude Code to help set up the repo, trace where the leftovers came from, run the build and tests, and draft the CHANGELOG entry and this description. I reviewed every line I'm submitting.
Checklist
All PRs
go build ./...passes locallygo test ./...passes locallyCHANGELOG.md(root) updatedIf
probe_agent/lib/changeddart analyze lib/passes: N/A, this PR doesn't touchprobe_agent/flutter testpasses: N/A, noprobe_agent/changesdart pub publish --dry-runpasses: N/A, noprobe_agent/changesprobe_agent/CHANGELOG.mdupdated: N/A, noprobe_agent/lib/changes (root CHANGELOG updated instead)probe_agent/README.mdupdated: N/A, nothing visible on pub.dev changedIf new ProbeScript commands or CLI flags were added
probe_agent/README.mdFeatures section updated: N/A, no new commands or flagswebsite/src/content/docs/doc page updated: N/A, no new commands or flagswebsite/astro.config.mjssidebar updated: N/A, no new doc pagesIf this is a release PR
probe_agent/pubspec.yamlversion bumped: N/A, not a release PRvscode/package.jsonversion bumped: N/A, not a release PRdocs/wiki/Home.mdcurrent version updated: N/A, not a release PR