Skip to content

propagate authentication errors from synchronous init #1478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HhH666-ux wants to merge 1 commit into
base: main
Choose a base branch
from
Open

propagate authentication errors from synchronous init #1478

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 13 additions & 21 deletions agentops/client/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

from agentops.client.api import ApiClient
from agentops.config import Config
from agentops.exceptions import ApiServerException, InvalidApiKeyException
from agentops.instrumentation import instrument_all
from agentops.logging import logger
from agentops.logging.config import configure_logging, intercept_opentelemetry_logging
Expand Down Expand Up @@ -93,7 +94,7 @@ def _set_auth_data(self, token: str, project_id: str):

HttpClient.set_project_id(project_id)

async def _fetch_auth_async(self, api_key: str) -> Optional[dict]:
async def _fetch_auth_async(self, api_key: str, raise_errors: bool = False) -> Optional[dict]:
"""Asynchronously fetch authentication token."""
try:
response = await self.api.v3.fetch_auth_token(api_key)
Expand All @@ -112,6 +113,10 @@ async def _fetch_auth_async(self, api_key: str) -> Optional[dict]:
else:
logger.debug("Authentication failed - will continue without authentication")
return None
except (InvalidApiKeyException, ApiServerException):
if raise_errors:
raise
return None
except Exception:
return None

Expand All @@ -121,28 +126,15 @@ def _start_auth_task(self, api_key: str):
return # Task already running

try:
loop = asyncio.get_event_loop()
if loop.is_running():
# Use existing event loop
self._auth_task = loop.create_task(self._fetch_auth_async(api_key))
else:
# Create new event loop in background thread
def run_async_auth():
asyncio.run(self._fetch_auth_async(api_key))

import threading

auth_thread = threading.Thread(target=run_async_auth, daemon=True)
auth_thread.start()
loop = asyncio.get_running_loop()
except RuntimeError:
# Create new event loop in background thread
def run_async_auth():
asyncio.run(self._fetch_auth_async(api_key))

import threading
# No running loop means init() was called synchronously. Authenticate
# before returning so a bad key fails here instead of being swallowed
# in a daemon thread and only showing up later as silent 401 exports.
asyncio.run(self._fetch_auth_async(api_key, raise_errors=True))
return

auth_thread = threading.Thread(target=run_async_auth, daemon=True)
auth_thread.start()
self._auth_task = loop.create_task(self._fetch_auth_async(api_key))

def init(self, **kwargs: Any) -> None: # Return type updated to None
# Recreate the Config object to parse environment variables at the time of initialization
Expand Down