Repository navigation
Conversation
HhH666-ux
force-pushed
the
fix/propagate-auth-errors
branch
from
November 6, 2026 04:50
4f7cf54 to
4694fdd
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Client.init()with an invalid API key returns successfully. The async auth refactor moved authentication into a daemon thread, soInvalidApiKeyException/ApiServerExceptionwere swallowed and the caller only found out later when exports failed with 401s.This keeps the background task for async callers, but when
init()runs without a running event loop (the synchronous API), it authenticates before returning and letsInvalidApiKeyException/ApiServerExceptionpropagate to the caller. Other unexpected errors are still swallowed as before, so the happy path does not change.Tests
pytest tests/integration/test_auth_flow.py -q— 2 passed (test_auth_flow,test_auth_flow_invalid_key)Fixes #1336