Repository navigation
D-TGL: F-LAND / F-DISCARD lab, Thought-Git lifecycle contract, post-merge record for #1923 - #1924
Conversation
…fiers F-LAND and F-DISCARD refresh_crate = prepare_refresh (&self, returns an owned PreparedRefresh, or None for an unchanged file) + commit_refresh. commit_refresh refuses a preparation made against an older graph generation (RefreshRefusal::Stale) before changing anything: two branches over one W0 that both mint symbols claim the same free position, so the second must be recomputed against the current W0. Lab only, crate-private; no Thought-Git wiring. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X6y3drwKSE2zSgoexheLFX
…8 bag contract; G9-G12 + EXO-148 production gates; F-LAND/F-DISCARD lab result Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X6y3drwKSE2zSgoexheLFX
…its merge point Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X6y3drwKSE2zSgoexheLFX
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 69216959ad
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…publication lab spec (D-TGL-PUB), boundaries B1-B5, falsifiers L1-L6 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X6y3drwKSE2zSgoexheLFX
…merge point Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X6y3drwKSE2zSgoexheLFX
…mmit (codex P2 on #1924) A read between prepare_refresh and commit_refresh (impact, closure take &self) can fill a closure cache the preparation did not see. It was built from the pre-commit edges, and commit kept it, so impact answered from the old graph. When the batch changes edges, commit now drops every cache it has no prepared refresh for. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X6y3drwKSE2zSgoexheLFX
…1a5sw D-TGL-PUB steps 1-2: BindStore::check_route, lab WalSink; codegraph stale-closure fix; post-merge record for #1924
Summary
#1923 was merged at
83ac4b3a8. Two commits pushed to its branch after that point never reachedmain. This PR carries them, the post-merge record for #1923, and two items from the operator review of this PR.The branch merges current
main(2e19a5adc) instead of rewriting history. There was no force push and nothing was lost.1. Codegraph lab: F-LAND and F-DISCARD (
ab9fb36f6)refresh_crateis nowprepare_refreshfollowed bycommit_refresh.prepare_refreshtakes&selfand returns an ownedPreparedRefresh, orNonewhen the file is unchanged.commit_refreshfirst checks the graph generation the change was prepared against. A mismatch returnsRefreshRefusal::Stalebefore anything changes.refoldbumps it.F-LAND. Two branches over one W0 each mint a new symbol, so both claim the same free position (the test asserts this).
m::bhas 5 call sites from two sources.F-DISCARD. Dropping a prepared branch leaves the snapshot unchanged and issues no map-table version.
2. Thought-Git lifecycle contract D-TGL (
4025292ea, docs only)thought-git-lifecycle-contract-v1.md:3. Post-merge record for #1923
PR_ARC_INVENTORY, LATEST_STATE, and the STATUS_BOARD rows D-CODEGRAPH-0-C2 and D-DYNBAG-4.
4. Release-profile check of the fence (operator review)
cargo test --release --lib: 7 passed.Ok(RefreshStats { edges_added: 6, symbols_appended: 1, .. }).debug_assert.5. G10 × G11 lab spec D-TGL-PUB (docs only)
g10-g11-atomic-publication-lab-v1.mdcovers prepared land, a fenced durable commit, crash recovery and branch-local routing.Boundaries read in code:
routerefuses onlyUnknownClassandOutsideReservation. The registry is insert-only, so a checked route intent never goes stale.check_routeexists. That is the one missing read-only addition.RouteVersionagain, so DT64 recovery needs a watermark. Codegraph recovery is idempotent through the digest skip.scan_sealedreturns landings without their payload, so land records must be read from the image.recover_and_applyis idempotent by watermark.Falsifiers L1–L6, each with a disable:
Fenced: nothing published.RouteVersionwould tick again.Nothing in the spec is implemented. The next three steps would each be their own reviewable change:
check_route, a labWalSink, and the L1–L6 test.Test Plan
cargo testincrates/lance-graph-codegraph, in both debug and release profiles: all pass. Clippy and fmt are clean.entries_index --check,append_only_gate, the supersession index,plan_dids, andcitation_decay --since origin/main.EXO-148 stays locked. Lab results do not satisfy any production gate. Not to be merged automatically.
🤖 Generated with Claude Code
https://claude.ai/code/session_01X6y3drwKSE2zSgoexheLFX