Repository navigation
D-TGL-PUB steps 1-2: BindStore::check_route, lab WalSink; codegraph stale-closure fix; post-merge record for #1924 - #1925
Merged
Conversation
…step 1) check_route applies route's two refusals (UnknownClass, OutsideReservation) without a route event or a new RouteVersion. route runs the same check before it writes (RouteLog::check), so the two cannot disagree. A checked intent stays valid: classes are only added and the answer does not read the route log. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X6y3drwKSE2zSgoexheLFX
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X6y3drwKSE2zSgoexheLFX
…merge point Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X6y3drwKSE2zSgoexheLFX
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…mmit (codex P2 on #1924) A read between prepare_refresh and commit_refresh (impact, closure take &self) can fill a closure cache the preparation did not see. It was built from the pre-commit edges, and commit kept it, so impact answered from the old graph. When the batch changes edges, commit now drops every cache it has no prepared refresh for. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X6y3drwKSE2zSgoexheLFX
…nd commit) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X6y3drwKSE2zSgoexheLFX
…tep 2) An in-memory WalSink, test-only, that honours the production writer contract: fence against the head (Fenced, nothing written), one version per commit, reconcile a re-submitted (cycle, batch_hash), HashConflict for another batch of a durable cycle, payload-free scan_sealed. Lab seams: injected faults (I/O before publish, Ambiguous after publish) and a read of the durable image, where recovery must find land records. lance-graph-planner is a dev-dependency only. The crate's own workspace patches the ndarray git coordinate to the sibling checkout, as the root workspace does, so the graph keeps one ndarray package. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X6y3drwKSE2zSgoexheLFX
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X6y3drwKSE2zSgoexheLFX
AdaWorldAPI
pushed a commit
that referenced
this pull request
Nov 2, 2026
…point Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X6y3drwKSE2zSgoexheLFX
AdaWorldAPI
added a commit
that referenced
this pull request
Nov 2, 2026
…1a5sw D-TGL-PUB step 3: G10 × G11 publication lab, falsifiers L1–L6; post-merge record for #1925
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR carries steps 1 and 2 of the G10 × G11 lab spec (
g10-g11-atomic-publication-lab-v1.md, D-TGL-PUB), the fix for the Codex P2 finding on the merged #1924, and the post-merge record for #1924. #1924 merged at7625567f9, before these commits. The branch merges currentmainand rewrites no history.Step 1:
BindStore::check_route(&self, position, class) -> Result<(), Refusal>route: the same two refusals (UnknownClass,OutsideReservation), no route event, and no newRouteVersion.routeruns this exact check before it writes (route_identity→RouteLog::check).Step 2: lab
WalSink(crates/lance-graph-codegraph/src/lab_wal.rs, test-only)An in-memory
WalSinkthat follows the production writer contract:Fencedagainst the head and writes nothing;(cycle, batch_hash)reconciles;HashConflict;scan_sealedreturns no payload.It adds two lab seams:
Ambiguousafter publish (crash boundary B3);image(cycle), the durable payload read that recovery must use.Dependencies:
lance-graph-planner,lance-graph-contractandtokio(rt) are dev-dependencies only.cargo tree -i ndarrayshows a single package. The CItestjob already checks out ndarray as a sibling.Stale closure cache between prepare and commit (Codex P2 on #1924)
A read between
prepare_refreshandcommit_refreshcould fill a closure cache from the pre-commit edges, andcommit_refreshkept it. When the batch changes edges, commit now drops every cache it has no prepared refresh for.Test Plan
dt64:
check_routeagrees withrouteon 5 cases;routedoes write;Lab
WalSink: 4 tests:Four disables, each red on its own test: dropping the fence, leaking the payload through
scan, skipping the reconcile lookup, and makingAmbiguouspublish nothing.Stale-closure fix:
lifecycle::a_closure_cached_between_prepare_and_commit_is_not_served_stale. The disable is red in both debug and release.Results:
-D warningsand fmt clean;Not implemented here: the L1–L6 test (step 3). EXO-148 stays locked. Not to be merged automatically.
🤖 Generated with Claude Code
https://claude.ai/code/session_01X6y3drwKSE2zSgoexheLFX