Repository navigation
dr: MapTable, the versioned global → local table (D-DT64-7 O5) - #1905
Merged
Merged
Conversation
A LocalMap is now read only under the frame it was sealed under; the coordinates revision is derived from the held maps (tile id + map digest), not passed in. Stored selections (D7') wait on O4. Design: plan §1e. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMNZqKXSaeb9g2ypywF
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMNZqKXSaeb9g2ypywF
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMNZqKXSaeb9g2ypywF
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
AdaWorldAPI
marked this pull request as ready for review
November 1, 2026 01:57
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…5 row) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMNZqKXSaeb9g2ypywF
This was referenced Nov 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
lance_graph_dt64::dr::MapTableholds every tile'sLocalMapunder oneFrameStore. It is additive; no existing signature changes.advance(source, relation_map, changes)inserts, replaces or removes tile maps, then re-seals. Thecoordinatesrevision is derived from the maps it holds: FNV-1a over(TileId, LocalMap::digest)in tile order. Callers no longer pass it in.map(&Frame, tile)returns the map only under the current seal:MapRead::Stale(CoordinatesChanged | FrameResealed | …);Stale(ForeignFrame), even at equal revisions;NoSuchTile.Before this change a
LocalMapcould be kept and read after its frame moved, andcoordinateswas whatever number the caller passed. O5 is a BindStore plan item (D-DT64-6 Amendment A; Litho is the mental model, not a component). Design: plan §1e.Not in this PR: stored selections (D7'). They wait on O4: does one
0xF###value name one stored selection, or a position in a wider basis?Validation
MapTabledid not exist.cargo test -p lance-graph-dt64: all green, including 4 new tests intests/dr.rs.xlog-relcomp-probe(litho.rs,gate_b.rs): all green and unchanged.cargo clippy -p lance-graph-dt64 --all-targets -- -D warnings: clean.mapturns 3 tests red.TileIdfrom the digest turnstile renamedred. The first version of that test only swapped two tiles' maps, and it stayed green without theTileIdbecause order alone changes the digest. A same-order rename case was added.Generated by Claude Code