Repository navigation
lance-graph-xlog: XLOG's admitted chain over Quack → mask-risc (D-XLOG-NATIVE-4) - #1907
Merged
Merged
Conversation
A LocalMap is now read only under the frame it was sealed under; the coordinates revision is derived from the held maps (tile id + map digest), not passed in. Stored selections (D7') wait on O4. Design: plan §1e. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMNZqKXSaeb9g2ypywF
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMNZqKXSaeb9g2ypywF
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMNZqKXSaeb9g2ypywF
…5 row) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMNZqKXSaeb9g2ypywF
…YNBAG-0, step 1) support = ScatterOrU32 per side + mask_and; bag count = GroupReduce Count per side + checked_binary_i64 (TRACKED, MISSING-3). No ndarray fold word left in native.rs. Public API unchanged; gate_b / litho stay the oracles. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMNZqKXSaeb9g2ypywF
…-0, step 2) bag_count_admitted runs only from an admitted Bag method whose words the caller reads (MISSING-1, probe-local) and from DR's Y map read under the caller's MapTable frame; a stale frame, an unread word, a Distinct method, or a retracted route (no binding) leaves nothing to run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMNZqKXSaeb9g2ypywF
…-0 gate 3) Queries read the intake's lanes and re-check its frame; no lookup after intake (MISSING-5 test). bag_count_admitted now runs over an Intake. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMNZqKXSaeb9g2ypywF
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMNZqKXSaeb9g2ypywF
…OG-NATIVE-4) The computation moves from the probe into a workspace crate: Intake, support, bag_count, bag_count_admitted, Word, refusals, over plain Bounds. No xlog-* or arrow dependency (N4); `and` is ndarray::simd::mask_and, the same symbol as lance-graph-onnx::and (N1, N5); tests against scalar enumeration under four bound combinations. The probe keeps admission and delegates. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMNZqKXSaeb9g2ypywF
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMNZqKXSaeb9g2ypywF
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
AdaWorldAPI
marked this pull request as ready for review
November 1, 2026 02:15
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1906 (D-DYNBAG-0), which is stacked on #1905 (
MapTable). Merge them in that order. Until they land, this diff includes their commits. This PR's own commits are the last two.What
A new workspace crate,
crates/lance-graph-xlog, holds the computation that D-DYNBAG-0 moved onto Quack → mask-risc. The probe's version of that code is moved out of the probe:Intake,support,bag_count,bag_count_admitted,Word,Support,NativeRefusal,BoundRefusal,ids,nonzero.Bounds { left, right }, so no XLOG type crosses into the crate.lance-graph-quack,lance-graph-mask-risc,lance-graph-dt64,lance-graph-contract, plusndarrayfor two calls only: the elementwise aliasandand the TRACKEDchecked_binary_i64(MISSING-3). Noxlog-*crate and no arrow.xlog-relcomp-probekeeps admission and delegates. It retainsadmit,admit_countandChainQuery::bounds(), and still runs both oracles (scalar enumeration and XLOG's RIR walk) plus the DR64 register differential.d-xlog-native-v1.mdAmendment D records the crate as created. Amendment C had already replaced §4's "ndarray only" shape.Gates (plan §6)
lance_graph_xlog::andisndarray::simd::mask_andandlance_graph_onnx::and, checked withfn_addr_eq.NativeRefusal, andBoundRefusal(stale frame, word with no reading, not a bag method).cargo tree -p lance-graph-xlog -e normal(19 lines) contains noxlog-*and no arrow.Validation
cargo test -p lance-graph-xlog: 4 passed.cargo clippy -p lance-graph-xlog --all-targets -- -D warnings: clean.cargo test --releasepasses every suite (1 test was#[ignore]d before this PR); clippy-D warningsis clean.Still open:
p(X, Z)and chains of more than two atoms are NATIVE and refused at admission.Generated by Claude Code