Repository navigation
feat(workspace): member sees 'starting' and held sends while their agent restarts (ent#1201, B) - #4429
Conversation
A person on an agent shared to them as a member (is_member_agent && !owned,
read off the card) is never told to ask an account to start it:
- portalUtils: viewerIsMemberTier, assistantStarting (the assistant_ready
progress step in progress) and memberTierRefusal. availabilityChip and
composerAvailabilityNotice take { memberTier, starting }: a member-tier
card reads "Restarting" / "Your assistant is restarting." with no owner,
and nothing at all while the assistant is starting.
- PortalConversation: a send while the member's assistant is starting is
held ("will send when it's ready"), sent when the step flips to done,
handed back as text if it failed or after 3 minutes, and kept as the
chat's draft on unmount. A 502 "needs to start it" refusal reads as
restarting for a member.
- PortalAgentDetails: the hard-coded detailed chip follows the same rule.
Tests: portalAvailabilityChip.spec.js (member-tier block, red on the base
for the owner-name assertions), portalMemberHeldSend.mount.spec.js and
portalMemberTierDetails.mount.spec.js (mounted; red before the wiring).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
When the roster says the viewer's own agent is still being set up (agent_setup_pending), the Workspace says so instead of "No agents shared with you yet": - clientPortal store: agentSetupPending (raised only by a roster that says exactly true) and refreshRoster(), a quiet re-read that never re-enters the loading phase and leaves the screen as it was on a failed read. - portalProgress store: startingFor(agent), off the one cached card. - PortalSidebar: an empty roster that is being set up shows one line, "Your assistant is being set up"; a member's row shows no chip while its assistant is starting (progress read for member rows only). - Portal.vue: the same line on the bare stage, where the conversation will mount; a quiet 3 s roster poll only while pending, stopped at a 3-minute ceiling (setupPollVerdict) with "This is taking longer than usual — we're looking into it."; a member's assistant_ready step flipping re-reads the roster once. Tests: portalRosterSetupPending.spec.js, portalSidebarSetupPending.mount, portalSetupPendingStage.mount (Portal.vue mounted, fake timers), startingFor in portalProgressStore.spec.js, setupPollVerdict in portalAvailabilityChip.spec.js; all red before the change. portalUnreadLiveness.spec.js's setInterval bound moves 2 -> 3 for the bounded set-up poll, with the reason in the test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…d comes back (ent#1201)
I1 — holding a send emptied the composer, and the write-through draft
persisted that empty field; only unmount wrote the held words back, and a
reload or a closed tab runs no unmount hook. While a send is held its words
are now the chat's draft (ahead of anything typed since, post-flush after
useComposerDraft's own write), and the draft lets go of them once the hold
ends — sent on the ready flip, or handed back to the composer.
I2 — a member-tier 502 ("its owner needs to start it", rewritten to
"restarting") returned no restoreText, so the words stayed only on the
struck, non-retryable message. It now hands them back to the composer the
way the #3460 refusal three lines above does.
Mutations (fix reverted from a scratch copy, restored byte-identical):
- held-draft watcher removed -> RED "survives a reload: the held words are
the chat's draft until sent or handed back"
- draft not released on send (`|| !h`) -> RED same spec ("hello there" vs '')
- restoreText dropped on memberCopy -> RED "hands the refused words back to
the composer"
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rity (ent#1201) Review follow-ups inside PR B's own files: - I5: past the 3-min poll ceiling the stage said "taking longer" while the sidebar still said "being set up". Both now read one pair of lines from portalUtils, and the shell passes setupOverdue to the sidebar. Mutations: wiring removed -> RED portalSetupPendingStage "stops after three minutes…"; sidebar ternary removed -> RED portalSidebarSetupPending "past the ceiling it says what the stage says". - I7: the member 502 rewrite matches free server text. A spec reads every availability refusal from client_portal/service.py and runs it through memberTierRefusal (consumer: CI). Mutation: frontend regex changed -> RED. - I6: the progress-store spec fixture renamed to a neutral member-bob / member-amy. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
/validate-pr — APPROVE (conditional), no blockersValidated against the stacked base
Warnings
Not run here — at retarget / before merge
|
2f1ad2e
into
feature/1201-member-handover-state
dolho
left a comment
There was a problem hiding this comment.
Reviewed with /validate-pr at 2ce7456aa (Lane B, stacked on #4428), against abilityai/trinity-enterprise#1209. Leaving a comment rather than an approval: one finding to settle first.
Verified
- The 8 touched spec files plus the raw-colour, loading-gate and source-text ratchets: 11 files, 95 passed. The five new specs mount components; none reads source text.
- A held send is kept as the chat's draft, sent when
assistant_readyleavesin_progress, and handed back to the composer onfailedor after 3 minutes. A send with files is not held, as documented. fetchRoster({ quiet: true })leavesloading,error,unavailableandrosterLoadedalone, and still handles a 401.- The member-tier copy names no account, and
memberTierRefusalfalls back to the server's words for any other viewer or refusal.
Finding (please settle before merge): the set-up state has no end for a person with nothing on the way
Details and proof are on abilityai/trinity-enterprise#1209: the provider reports "pending" for anyone who accepted the current terms and has no member row, however long ago. In this PR that becomes:
watch(() => store.agentSetupPending)inPortal.vuestarts the 3-secondrefreshRosterpoll whenever the flag is true, with or without agents on the roster. The 3-minute ceiling is in-memory, so it restarts on every Workspace load: up to 60 roster reads per load, each asking the provider again.- With an empty roster,
PortalSidebar.vueand the stage show the set-up line, then "taking longer — we're looking into it", in place of "No agents yet. Create one →" for a platform user.
On an existing instance that turns member agents on, that is every user who had already accepted the terms. The fix belongs in the provider (bound the no-row case by the acceptance's age); if you would rather bound it here, remember the ceiling across loads.
Non-blocking
memberTierRefusalmatches the server's sentence with/needs to start it/. The specs pin the same string, but nothing ties it toclient_portal/service.py:614-622; if that copy changes, members quietly get the owner wording back. A machine-readable code on the 502 would remove the coupling.portalUnreadLiveness's timer cap goes 2 → 3 (disclosed in the body). Noting it because it loosens a guard.- Base is
feature/1201-member-handover-state; retarget todevafter #4428 merges, as the body says. CI here showschanges/reportcancelled, which is the stacked base, not a failure.
What
Workspace UI for a member while their own agent is set up or restarted (abilityai/trinity-enterprise#1201, part B, stacked on part A — base
feature/1201-member-handover-state).agent_setup_pendingis true (Portal.vue,PortalSidebar.vue,portalProgressstore).is_member_agent && !owned); a stopped member agent outside a hand-over shows "Restarting".portalMemberHeldSend.mount,portalMemberTierDetails.mount,portalRosterSetupPending,portalSetupPendingStage.mount,portalSidebarSetupPending.mount, plus updates.Rulings carried
Review + security
Reading review: MERGEABLE AFTER FIXES. Fixed on this branch: I1 held send lost on reload (
3a0a7a1e5), I2 refused member send was a dead end (3a0a7a1e5), and three cheap items — set-up sidebar line past the ceiling, refusal copy parity (2ce7456aa). Each fix has a spec that goes red when the fix is reverted./cso --diff: nothing at ≥8/10.Builder deviations, reviewed: liveness timer cap 2→3 (for the 3 s poll); messages with files attached are not held; the member refusal is recognised by the server's "needs to start it" text (no category field).
Tests
Fix step: 11 files / 95 tests (touched specs + source-text, raw-color, loading-gate ratchets); neighbours (every
portal*, draft, composer, turnCancel spec) 176 files / 2,781 tests passed. Raw colors: 0 raw non-gray, 0 hardcoded in the touched components;PortalConversationsemantic tokens 52→54. Full vitest was not run to completion (sweep hit its 560 s cap at ~2,365 tests, 0 failures). Stacked PR:backend-unit-testand CodeQL do not run until this retargetsdev.Before merge
dev(first full CI run).client_portal/models.py/service.pythrough part A. fix(voice): Workspace read-aloud scrubs staged credential values before TTS, and the parity guard pins both remaining speech sinks (#4359) #4361, feat(workspace): Projects working-environment epic — steward access, roles, steward at creation, scoped people reads (abilityai/trinity-enterprise#1137) #4395 test-merge clean.in_progressstep) — fix dispatched on part A's enterprise branch; this PR re-validates only if that touches it. W4portalUnreadLivenesstimer cap 2 → 3 — disclosed, the guard is looser.Handoffs
Part of abilityai/trinity-enterprise#1201.
🤖 Generated with Claude Code